-
Notifications
You must be signed in to change notification settings - Fork 49
Editorial: To address issue 140 #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think reordering the section will help the reader
@samuelweiler, thanks for the review and additional comment. I hope this update does the trick. |
this resolves the suggestion. One additional suggestion: especially since "cryptogram" isn't really defined in the spec, can you provide a citation back to the verification algorithm - show where this check is performed? (8.1, #2, #5? Also, should the sub-steps have letters instead of numbers?) And maybe a different term is still more appropriate? I also think there are more opportunities for trimming some words, though it's not necessary. |
You mentioned a citation back to the verification algorithm. The proposed text includes a link to "8.1" but uses different verbiage to refer to that section. (Also, I did not not find other references to "verifying the cryptogram", so this seems to be the only one.) I hope this address your request for a citation. |
Looks good to me. |
SHA: cd8781c Reason: push, by @samuelweiler Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Editorial. Addresses #140.
Preview | Diff