[Spec] Remove references to create in cross origin iframe #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WebAuthn specification now allows credential creation in a cross origin iframe, as of w3c/webauthn#1801. As such, SPC no longer needs to override or add this behavior. We do retain (for now) the ability for the `"payment"` permission policy to allow credential create in an iframe, instead of requiring `"publickey-credentials-create"`. This should be removed one day, but one small step to unification at a time :). There is a small web-compat issue here. In the case of no transient user activation, the SPC specification used to throw a `SecurityError` error. However WebAuthn throws a `NotAllowed` error instead. See also Chrome bug https://crbug.com/41484826 Fixes #267
stephenmcgruer
force-pushed
the
remove-create-in-cross-origin-iframe
branch
from
4728e88 to
9ada5e5
Compare
|
This one might warrant some discussion in the WPWG, really just as a heads up to the changing error type - which will only happen for realz when we fix https://crbug.com/41484826 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WebAuthn specification now allows credential creation in a cross origin iframe, as of w3c/webauthn#1801. As such, SPC no longer needs to override or add this behavior.
We do retain (for now) the ability for the
"payment"permission policy to allow credential create in an iframe, instead of requiring"publickey-credentials-create". This should be removed one day, but one small step to unification at a time :).There is a small web-compat issue here. In the case of no transient user activation, the SPC specification used to throw a
SecurityErrorerror. However WebAuthn throws aNotAllowederror instead. See also Chrome bug https://crbug.com/41484826Fixes #267
Preview | Diff