Moves the definition of Flatten(..) and Card(..) #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallTed
reviewed
Dec 14, 2023
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
rubensworks
approved these changes
Jan 9, 2024
Tpt
approved these changes
Jan 11, 2024
Tpt
added
the
spec:editorial
TallTed
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions Flatten(..) and Card(..) are currently defined at the end of Sec.18.5.1 Aggregate Algebra, directly before Sec.18.5.1.1 Set Functions. There is no explanation why these functions are needed.
Since the main purpose of these functions is to be helper functions that are used for defining the set functions in Sections 18.5.1.2 to 18.5.1.8, I find it much more natural to introduce these two functions in Sec.18.5.1.1 Set Functions.
Hence, this PR moves the definitions of these two functions into Sec.18.5.1.1 Set Functions and adds a sentence that introduces the purpose of these two functions.
Additionally, the PR improves the readability of the definition of Flatten.
Preview | Diff