-
Notifications
You must be signed in to change notification settings - Fork 2
Adds dark mode and simplify CSS #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- remove class="box", the code already has a different background color - remove class="reference" that is unused - drop the style block that is unused
|
Nice! FYI, I'm about to add some improved CSS to rdf-common, which I'm trying out on the primer in w3c/rdf-primer#24. (I'm also adding opt-in improved syntax highlighting.) I don't think this needs much coordination though; in fact, if this PR is merged that makes it simpler for me/us to try out if the upcoming addition to rdf-common looks good (it'll probably be opt-in for clarity). Specifically, the syntax highlighting in user-set light mode will be improved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In light mode, the background grey of boxes is much too close to the page background white.
Indeed, it's very close. We might customize it but I am slightly afraid it might clash in unexpected ways with syntax highlighting. If you don't think it's a problem, do you have a favorite color? |
Dark mode is OK-ish for now - the json background is distinct mainly because the main background is hard black rather than a "dim grey" dark mode. (FWIW: I use github "Dark dimmed" in GH; Hard black is like GH "Dark contrast") |
Make sense! However, should we customize it here or suggest a change to ReSpec? It seems to me it's a ReSpec concern and not something specific to our documents. |
|
3.2.2 Encoding RDF terms has also changed in light-mode. That did just have borders. |
Indeed. Fixed. Sorry for missing that. |
Preview | Diff