-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update contributors. #50
Conversation
// Find the maximum length of the first part (before the space) | ||
const maxLength = Math.max(...users.map(user => user.split(" ")[0].length)); | ||
|
||
// Right-align the first component and format the strings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this does not "do the right thing" for Jose Emilio Labra Gayo,
though I see that by some other magic the sort-order is correctly based on the third component.
It's unclear to me whether Thomas Pellissier Tanon
should be ordered under P
or T
. (Different sources show both Pellissier Tanon
and Tanon
are treated as his family name.) Perhaps @Tpt could weigh in? Likewise Jeffrey Phillips Freeman
. Thoughts, @freemo (assuming I've found the right GitHub user)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an approximation, and beyond the scope of this work to handle all variations in how names are represented (is there even a way to know algorithmically?). In any case, the result is just whitespace in HTML which is eliminated when rendering. As the list is generated automatically, the need to be able to easily inspect the HTML list of people is of limited value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"the list is generated automatically" and that's problematic, as I've stated (I thought, clearly).
If ordered by family name, there must be a way to detect what portion of the namestring is the family name.
If there isn't an easy way that can be applied to the output of the magic script/function, then the authors of that magic script/function ought to be looking at an issue report, by whatever means possible.
I really wish the specifics of this PR had been worked out on one document, and not applied across the board until after issues such as this had been resolved there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"the list is generated automatically" and that's problematic, as I've stated (I thought, clearly).
Do you seriously think we should maintain the list by hand? I'm struggling to understand the basis for your concern about this. I believe the order returned by the W3C API is correct. Your issue is seems to be the way the whitespace is handled. This is entirely moot in the rendered HTML, and is only for an aesthetic presentation of the raw HTML. I really don't see why this matters.
The W3C user records separate Given Name from Family Name, it's just that the API doesn't return these as separate fields, but I believe they order the records based on the family name, there's just no way for me to dissect this after the fact.
No description provided.