Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix three deprecated packages #278

Merged
merged 2 commits into from
Dec 15, 2015
Merged

Fix three deprecated packages #278

merged 2 commits into from
Dec 15, 2015

Conversation

tripu
Copy link
Member

@tripu tripu commented Dec 4, 2015

npm has been throwing these errors for a long time:

npm WARN deprecated CSSselect@0.4.1: the module is now available as 'css-select'
npm WARN deprecated lodash@2.4.2: lodash@<3.0.0 is no longer maintained. Upgrade to lodash@^3.0.0.
npm WARN deprecated CSSwhat@0.4.7: the module is now available as 'css-what'

CSSselect and CSSwhat have not changed in ca. two years; lodash was stuck at a major version that is marked as deprecated. All these three are dependencies of whacko.

I submitted a couple of PRs for whacko to get this updated; those were promptly merged, and a new version of whacko published to npm (the previous one was eight months old). This PR incorporates that change in Specberus.

There was an issue with the new package css-select. My solution is to replace $.find('> foo') with $.children('foo'), more or less as suggested here (see also cheeriojs/cheerio#780, cheeriojs/cheerio#728 and cheeriojs/cheerio#635).

deniak added a commit that referenced this pull request Dec 15, 2015
@deniak deniak merged commit 8e36e59 into master Dec 15, 2015
@deniak deniak deleted the tripu/fix-deprecated-packages branch December 15, 2015 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants