This repository was archived by the owner on Sep 19, 2018. It is now read-only.
Partially update idlharness to Promise-returning attributes now rejecting instead of throwing on invalid this and the like. #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 20, 2017
…ting instead of throwing on invalid this and the like.
bzbarsky
force-pushed
the
promise-attrs
branch
from
7447866 to
483e4c5
Compare
Ms2ger
approved these changes
Jan 23, 2017
|
Feel free to cherry-pick those changes in https://bugzilla.mozilla.org/show_bug.cgi?id=1332713 , if that's helpful. |
Way ahead of you, because otherwise Gecko would have test failures all over. ;) See the diff in part 4 there. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is