-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show i18n best practice in example #211
Comments
We should add an example that demonstrates how to secure an internationalized string. |
The issue was discussed in a meeting on 2023-10-17
View the transcript1.1. Show i18n best practice in example (issue vc-data-integrity#211)See github issue vc-data-integrity#211. Manu Sporny: We have started the CR transition for the DI specs and JSON schema, I made a mistake and didn't properly request i18n review, but fortunately Addison took care of this for us. He would like to see an example of an i18n string. Brent Zundel: The plan, as I understand it, is to raise a PR to add a non-normative i18n example to data integrity and then merge it at some point before the 7 day window. |
Pasting in the I18N comment: Example 1
Also found in the other docs in this review, e.g.
There are a number of examples that have title as a string (as shown above). These ought to use the language and direction metadata we've discussed in data model or use a non-language string as the example. |
The examples in the core spec have been updated to use a non-language string as the example. The test vectors will need to be updated later as @Wind4Greg is soon-to-be/currently on leave and unable to update the test vectors. Since the test vectors are non-normative, we can update them at any time. I've added a tracking issue for this to make sure that we do this as soon as @Wind4Greg is back: #218 |
PR #213 has been merged, closing. |
A quick i18n review by @aphillips requested that we demonstrate i18n best practices:
w3c/i18n-activity#1771
This issue tracks that concern such that it's addressed before the DI specs go to CR.
The text was updated successfully, but these errors were encountered: