Skip to content

Conversation

@Wind4Greg
Copy link
Collaborator

@Wind4Greg Wind4Greg commented Jul 18, 2023

This PR addresses issue #114. By adding the optional nonce attribute to a proof and providing some explanatory text.


Preview | Diff

@Wind4Greg Wind4Greg requested a review from msporny as a code owner July 18, 2023 18:11
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
index.html Outdated
Comment on lines 533 to 534
field is to increase privacy by decreasing linkability to deterministically
generated signatures.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure nonce actually does what it's saying here when paired w/ a VC that has linkable values in it (like a deterministic signature, for example). Just noting that the reason for the property is not easily achieved unless you're using unlinkable stuff everywhere.

This is not a blocking comment, just noting a concern with the current language. The language is true, but only in a certain context (that is not explained in the example).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this topic seems to be covered in section 6.1 on (Privacy Considerations/Unlinkability) where both data and signature linkability are discussed.

Co-authored-by: Dave Longley <dlongley@digitalbazaar.com>
Copy link

@awoie awoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@msporny
Copy link
Member

msporny commented Jul 28, 2023

Normative, multiple reviews, changes requested and made, no objections, merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants