-
Notifications
You must be signed in to change notification settings - Fork 21
Add creator generated nonce to proof. #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
index.html
Outdated
| field is to increase privacy by decreasing linkability to deterministically | ||
| generated signatures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure nonce actually does what it's saying here when paired w/ a VC that has linkable values in it (like a deterministic signature, for example). Just noting that the reason for the property is not easily achieved unless you're using unlinkable stuff everywhere.
This is not a blocking comment, just noting a concern with the current language. The language is true, but only in a certain context (that is not explained in the example).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this topic seems to be covered in section 6.1 on (Privacy Considerations/Unlinkability) where both data and signature linkability are discussed.
Co-authored-by: Dave Longley <dlongley@digitalbazaar.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thank you
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
|
Normative, multiple reviews, changes requested and made, no objections, merging. |
This PR addresses issue #114. By adding the optional
nonceattribute to a proof and providing some explanatory text.Preview | Diff