Add expires proof attribute #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrizagidulin
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
👍
Thanks for adding this, @Wind4Greg.
(I'm not sure whether we should go so far as to say SHOULD, but this is a step in the right direction).
msporny
requested review from
Sakurann,
TallTed,
brentzundel,
brianorwhatever,
davidlehn,
dlongley,
iherman,
jandrieu and
longpd
msporny
approved these changes
Jul 23, 2023
msporny
requested changes
Jul 23, 2023
There was a problem hiding this comment.
Agree with @dmitrizagidulin... this shouldn't be a SHOULD, too strong. Suggest that it's OPTIONAL.
Co-authored-by: Manu Sporny <msporny@digitalbazaar.com>
dlongley
approved these changes
Jul 24, 2023
TallTed
suggested changes
Jul 24, 2023
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
msporny
approved these changes
Jul 28, 2023
|
Normative, multiple reviews, changes requested and made, no objections, merging. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #78 by adding the
expiresattribute to the definition of the proof. Note that this term is already defined in the data integrity context.Preview | Diff