Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we bundle contexts for credentialSchema and credentialStatus int he v2 core context? #1134

Closed
OR13 opened this issue May 18, 2023 · 7 comments · Fixed by #1178
Closed
Assignees

Comments

@OR13
Copy link
Contributor

OR13 commented May 18, 2023

The argument for doing so is that they are used by data integrity proofs, and this would make things easier for developers.

If we don't do this, we should make sure to include normative guidance on adding context values to the context array when these features are used, to avoid confusion regarding term definitions.

@OR13 OR13 changed the title Should we bundle contexts for credentialSchema and credentialStatus int he v2 core context Should we bundle contexts for credentialSchema and credentialStatus int he v2 core context? May 18, 2023
@iherman
Copy link
Member

iherman commented May 18, 2023

(Meta comment.)

This issue seems to refer to the same underlying question than, for example, issues #1091 or #1090 (I did not do an exhaustive search). That question can be formulated as:

Should the V2 Core context include only terms that are strictly defined in the VCDM specification, or should it also include references to other terms, constructions, etc.?

To make it clear, the current context is based on the answer "no". If the answer is "yes", then the v2 context should be significantly pruned, removing the terms listed in the issue title, the terms that are currently defined in other specs or vocabulary, like DI, ODRL, or schema.org specs, and would also lead to the removal of the @vocab statement.

Note that the question is also closely related to #1103.

I would propose to close this issue and open an issue with that question instead. That would also makes it easy to handle #1091 and #1090 (and possibly others).

@OR13
Copy link
Contributor Author

OR13 commented Jun 28, 2023

Noting the current vc json schema does not require context bundling, see https://w3c.github.io/vc-json-schema/

@OR13
Copy link
Contributor Author

OR13 commented Jun 28, 2023

@decentralgabe you are volunteered for this.

@decentralgabe
Copy link
Contributor

Does bundling context meaning adding term definitions for JsonSchema2023 and CredentialStatusList2021 etc in the core context? If so I'm willing to make that change.

@iherman
Copy link
Member

iherman commented Jun 28, 2023

The issue was discussed in a meeting on 2023-06-28

  • no resolutions were taken
View the transcript

2.9. Should we bundle contexts for credentialSchema and credentialStatus int he v2 core context? (issue vc-data-model#1134)

See github issue vc-data-model#1134.

Brent Zundel: #1134 - orie?

Orie Steele: have already merged pull request to merge RDF classes to credentialStatus but have had other complaints with other values added.
… might leave this open if we want to bundle term defs with VC Data.

Manu Sporny: should bundle this. This will make developer lives easier.

Brent Zundel: looks like this is before CR.

Dave Longley: +1 to bundle things we agree make sense for developers to use.

Orie Steele: volunteers Gabe ;-).

Gabe Cohen: will be take it on.

@OR13
Copy link
Contributor Author

OR13 commented Jun 30, 2023

@decentralgabe yes, assume W3C will define the URLs for them, same as it did for "VerifiableCredential".

@decentralgabe
Copy link
Contributor

decentralgabe commented Jul 11, 2023

@msporny should this be re-opened to add CredentialStatusList2021? I can take that too

edit: #1194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants