Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove evidence #1092

Closed
wants to merge 1 commit into from
Closed

Remove evidence #1092

wants to merge 1 commit into from

Conversation

OR13
Copy link
Contributor

@OR13 OR13 commented Apr 18, 2023

Remove proposed term from v2 context

Addresses #1090


Preview | Diff

Remove proposed term from v2 context

Addresses #1090
Copy link
Member

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1 for the following reasons:

  • This term has already been used as an extension point in the VC Specifications Directory.
  • It only impacts JSON-LD implementations (and the cost is a handful of bytes for a context that is permanently cached and never downloaded).
  • There is active interest in this extension point (as evidenced by the discussion on the calls and the registration of an extension specification).

@iherman
Copy link
Member

iherman commented Apr 19, 2023

-1, see #1093 (comment)

@OR13
Copy link
Contributor Author

OR13 commented Apr 19, 2023

As I stated on the call.

If the working group has agreed to this term, as a normative requirement, it should not be reserved, and it should be defined in the TR AND in the JSON-LD context.

We should avoid bundling non normative stuff into the JSON-LD context, since they are cached, they can be split by normative and non normative easily, and then implementers can more easily signal their intention to use experimental extensions.

Copy link
Contributor

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1 This will lead to mistakes because of @vocab being in the core context.

@David-Chadwick
Copy link
Contributor

-1 from me also

@awoie
Copy link
Contributor

awoie commented Apr 24, 2023

-1 from my end as well since OIDF eKYC folks are using it.

@msporny msporny added DO NOT MERGE PR contains something that should not be merged. discuss labels Apr 27, 2023
@brentzundel
Copy link
Member

There does not seem to be a path toward consensus that would result in merging this PR.
I am adding the pending-close label and will close in 1 week if consensus still seems unlikely.

@brentzundel brentzundel added pending close Close if no objection within 7 days and removed DO NOT MERGE PR contains something that should not be merged. discuss labels May 3, 2023
@OR13
Copy link
Contributor Author

OR13 commented May 4, 2023

I thought we had agreement, that we would be reserving this URL and term name, and not defining it or using it in the v2 spec?

@msporny
Copy link
Member

msporny commented May 13, 2023

I thought we had agreement, that we would be reserving this URL and term name, and not defining it or using it in the v2 spec?

Removing the declaration from the v2 context (what this PR dos) is something that we did not have consensus on, and are unlikely to get consensus on it. It's been a week since being marked pending close. Closing.

@msporny msporny closed this May 13, 2023
@martyr280
Copy link

we have 2 different implementations of evidence usage both in an open source project and production product.

@msporny msporny deleted the remove-evidence-from-v2-context branch July 27, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending close Close if no objection within 7 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants