Skip to content

Conversation

@andresuribe87
Copy link
Contributor

This PR fixes #1148 by slightly tweaking the language.

@TallTed
Copy link
Member

TallTed commented Jun 29, 2023

I cannot edit the SVG source in this PR, but I have two suggested changes, removing RFC normative language, and matching capitalization of the rest of the illustration.

  1. line 70, from —

    <text x="380" y="385" font-weight="bold">May not preserve privacy</text>
    

    — to —

    <text x="380" y="385" font-weight="bold">might NOT preserve privacy</text>
    
  2. line 75, from —

    <text x="540" y="495" font-weight="bold">MAY preserve privacy</text>
    

    — to —

    <text x="540" y="495" font-weight="bold">MIGHT preserve privacy</text>
    

Copy link
Contributor

@OR13 OR13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably want to avoid normative language, even in diagrams, suggest "might" or something similar... Good PR though.

@TallTed
Copy link
Member

TallTed commented Jun 30, 2023

Probably want to avoid normative language, even in diagrams, suggest "might" or something similar...

Yeah, that's what's in my suggestion, above...

Copy link
Member

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Please make the changes requested by @TallTed and @OR13 so we can merge the PR.

@andresuribe87
Copy link
Contributor Author

Thanks @TallTed ! Applied in 7e36c77

@msporny
Copy link
Member

msporny commented Jul 4, 2023

Editorial, multiple reviews, changes requested and made, no objections, merging.

@msporny msporny merged commit 7c44300 into w3c:main Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check status privacy

6 participants