Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pointers back to Data Integrity Privacy and Security Considerations sections #33

Merged
merged 3 commits into from
Aug 26, 2023

Conversation

msporny
Copy link
Member

@msporny msporny commented Aug 19, 2023

This PR attempts to address issue #29, raised by the PING and security review, by pointing back to the Data Integrity Security and Privacy Considerations section.

/cc @kdenhartog


Preview | Diff

Copy link
Member

@kdenhartog kdenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reference the vc-data-model spec as well? There's additional points in there that are worth considering in here and it may (if the WG is fine with listing once in data model spec) reduce the number of considerations that need to be redundantly placed across all specs related to the same problems.

Copy link
Member

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar and punctuation fixes

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@msporny
Copy link
Member Author

msporny commented Aug 26, 2023

Can we reference the vc-data-model spec as well? There's additional points in there that are worth considering in here and it may (if the WG is fine with listing once in data model spec) reduce the number of considerations that need to be redundantly placed across all specs related to the same problems.

This specification (and soon, all of the cryptosuite specifications), ask the reader to consider the Security and Privacy consideration sections in the Data Integrity specification, which then asks the reader to consider the Security and Privacy consideration sections in the Verifiable Credentials specification. While we /could/ repeat the same language that's in the Data Integrity specification (that tells the reader to consider the Security and Privacy Considerations for VCs), we'd be duplicating guidance (with, arguably, not much more of an effect).

So, in the name of reducing the duplication of guidance, I'm suggesting that just pointing back to DI spec, which points back to the VC spec, is enough. If you feel strongly about duplicating the guidance, we can raise another PR that copy-pastes the text from the DI spec into each cryptosuite spec.

@msporny
Copy link
Member Author

msporny commented Aug 26, 2023

Editorial, multiple reviews, changes requested and made, justification provided for not making one change, no objections, merging.

@msporny msporny merged commit 7f709c1 into main Aug 26, 2023
@msporny msporny deleted the msporny-ref-di-secpriv branch August 26, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants