Additional Test Vectors #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wind4Greg
requested review from
msporny,
martyr280 and
seabass-labrax
as code owners
TallTed
requested changes
Dec 18, 2024
| } | ||
| }, | ||
| "name": "Employment Authorization Document", | ||
| "description": "Example Country Employment Authorization Document.", |
There was a problem hiding this comment.
Suggested change
| "description": "Example Country Employment Authorization Document.", | |
| "description": "Employment Authorization Document for Example Country.", |
There was a problem hiding this comment.
or maybe
Suggested change
| "description": "Example Country Employment Authorization Document.", | |
| "description": "Example Employment Authorization Document for Country.", |
There was a problem hiding this comment.
@TallTed, @dlongley or @msporny I took the unsigned inputs from the VC playground with some modifications (removed render method, substituted single pixel image for long PNG). Any changes to the input JSON file requires rerunning test vector generation code and changes derived/generated test vectors. Can folks come to an agreement on any changes to inputs (or not) then I will rerun the vectors.
| } | ||
| }, | ||
| "name": "Employment Authorization Document", | ||
| "description": "Example Country Employment Authorization Document.", |
| } | ||
| }, | ||
| "name": "Employment Authorization Document", | ||
| "description": "Example Country Employment Authorization Document.", |
| "image": "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAADUlEQVQIW2P4z/DiPwAG0ALnwgz64QAAAABJRU5ErkJggg==" | ||
| }, | ||
| "name": "Permanent Resident Card", | ||
| "description": "Government of Utopia Permanent Resident Card.", |
There was a problem hiding this comment.
Suggested change
| "description": "Government of Utopia Permanent Resident Card.", | |
| "description": "Permanent Resident Card from Government of Utopia.", |
TestVectors/employmentAuth.json
Outdated
| } | ||
| }, | ||
| "name": "Employment Authorization Document", | ||
| "description": "Example Country Employment Authorization Document.", |
| "image": "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAADUlEQVQIW2P4z/DiPwAG0ALnwgz64QAAAABJRU5ErkJggg==" | ||
| }, | ||
| "name": "Permanent Resident Card", | ||
| "description": "Government of Utopia Permanent Resident Card.", |
…ents in description field.
…te all derived test vector files impacted by this change.
msporny
approved these changes
Jan 2, 2025
|
Editorial, multiple reviews, changes requested and made, no objections, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This informative PR adds four additional sets of test vectors:
ecdsa-rdfc-2019for curves P256 and P384 based on an employment authorization document example.ecdsa-sd-2023. One based on an employment authorization document and another based on a permanent resident card example.The existing
ecdsa-sd-2023example was renamed and additional text was added to point out that this example demonstrates handling of arrays and nested objects in an SD situation.Preview | Diff