Address kid
#163
Address kid
#163
Conversation
|
Looks great! Though I think there might be a typo in the links to "DID URL" -- they point to "relative DID URL": I believe there are a few places in the changes that have this typo. If this is intentional, then please ignore this comment. |
|
It is intentional, I found that section most helpful in explaining the difference. |
| <!-- REGULAR URLS via "issuer" and "holder" --> | ||
| <p> | ||
| When the <a data-cite="VC-DATA-MODEL#dfn-issuers">issuer</a> is identified as a [[URL]], | ||
| the <a href="#kid">kid</a> MUST be an absolute [[URL]] to a verification method listed in a controller document. |
There was a problem hiding this comment.
Can "controller document" be a reference to a defined term?
There was a problem hiding this comment.
sadly not yet, this is due to the dialog regarding data integrity defining controller document.
| // ... | ||
| } | ||
| </pre> | ||
| <pre class="example" title="An kid as an absolute DID URL"> |
There was a problem hiding this comment.
| <pre class="example" title="An kid as an absolute DID URL"> | |
| <pre class="example" title="A kid as an absolute DID URL"> |
| <!-- REGULAR URLS via "iss" --> | ||
|
|
||
| <p> | ||
| When <a href="iss">iss</a> is a present, and is a [[URL]], |
There was a problem hiding this comment.
| When <a href="iss">iss</a> is a present, and is a [[URL]], | |
| When <a href="iss">iss</a> is present, and is a [[URL]], |
| </p> | ||
|
|
||
| <p class="issue" title="(AT RISK) Feature depends on demonstration of independent implementations"> | ||
| This normative statement depends on a -00 IETF OAUTH WG Adopted draft. |
There was a problem hiding this comment.
| This normative statement depends on a -00 IETF OAUTH WG Adopted draft. | |
| This normative statement depends on a | |
| <a href="https://datatracker.ietf.org/doc/html/draft-ietf-oauth-sd-jwt-vc-00#name-jwt-issuer-metadata">-00 IETF OAUTH WG Adopted draft</a> |
|
@OR13 -- Please let me know if you need a PR from me for the above minor tweaks to this. I would have preferred to submit them as change requests before this PR was merged, but time travel remains tragically unavailable. |
|
@TallTed please raise a PR to make these suggestions. |
|
Done. See #171. |
Attempt to close remaining
kidissues: #30 and #117Preview | Diff