Render section references #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selfissued
requested review from
msporny,
iherman,
decentralgabe and
brentzundel
iherman
requested changes
Mar 29, 2024
There was a problem hiding this comment.
The correct syntax is, e.g. <a href="#secure-with-hose">. Without the '#' the reference is to an outside resource identified by a relative URI. With '#' it is a fragment reference.
The only magic respec does is, when a fragment URI is used, is to extract the section title and put it into the text.
|
I applied your syntax suggestion, Ivan. Thanks! |
|
Looking at https://pr-preview.s3.amazonaws.com/selfissued/vc-jose-cose/pull/263.html#conformance-classes it seems to work properly now... |
iherman
approved these changes
Mar 29, 2024
decentralgabe
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #262
I'm guessing that we need the href values to point to fragment identifiers created from the section names in order for them to render correctly.
Preview | Diff