Fix phrasing, add spec links #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selfissued
reviewed
Jun 27, 2024
index.html
Outdated
| @@ -1525,7 +1526,8 @@ <h2 id="vp-ld-json-jwt"><code>application/vp-ld+jwt</code></h2> | |||
| <code>application/vp-ld+jwt</code> Media Type specifically for | |||
| identifying a <a data-cite="JWT"></a> | |||
| with a payload | |||
| conforming to Verifiable Presentations. | |||
| conforming to the <a data-cite="VC-DATA-MODEL-2.0#verifiable-presentations"> | |||
| Verifiable Presentation Data Model</a>. | |||
There was a problem hiding this comment.
I'm not all that comfortable elevating "Verifiable Presentation Data Model" to a thing. The phrase is only used once in VCDM and then it's not capitalized.
It's more wordy, but I'd happier with something like "conforming to the Verifiable Presentations definition in the Verifiable Credential Data Model.
selfissued
requested changes
Jun 27, 2024
selfissued
approved these changes
Jun 28, 2024
|
Editorial; merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #276
Preview | Diff