Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsso-core:partOfVehicle object property is unnecessary #31

Open
jdacoello opened this issue Mar 19, 2022 · 3 comments
Open

vsso-core:partOfVehicle object property is unnecessary #31

jdacoello opened this issue Mar 19, 2022 · 3 comments

Comments

@jdacoello
Copy link

The object property vsso-core:partOfVehicle is unnecessary.
To be able to connect components to the Vehicle (and to replicate the VSS tree), it is enough to add the transitive characteristic to vsso-core:partOf.

image

@felix-loesch
Copy link

Should the Vehicle Component's not have a VehicleComponentRoot element? In my opinion the assignment of Vehicle Component to a concrete vehicle instance (e.g. BMW 320 with specific VIN) should be done at instance level.

@jdacoello
Copy link
Author

jdacoello commented Mar 19, 2022

VehicleComponentRoot is a concept that doesn't exist in the current vsso-core.

So far, there were:

  • partOf
    • According to the definition: "This property is used to built a partOf hierarchy of VehicleComponents instances."
  • partOfVehicle
    • According to the definition: "This properties conncects VehicleComponents instances with an instance of a Vehicle."

In any case, the domain and range defined in vsso-core act on instances only.

If you look at the .ttl generated from vss, the property partOfVehicle is not even used. This is something that can be inferred just by adding the transitive characteristic. In other words, the intended function of this (extra) property can be easily handle with SPARQL.

Other details can be shaped once the specific vehicle properties and/or components are changed to be instances, as it is discussed in #22.

@danielwilms
Copy link
Contributor

We need an example on how it could be used and decide based on that. partOf and partOfVehicle indeed most likely to be redundant, but side effects to disjoint classes VehicleComponent vs Vehicle. Vehicle has two roles, one as root of the structure one as a concrete vehicle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants