-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sub-classes vs. Instantiation of existing VSS concepts #22
Comments
As discussed in the VSS Ontology Workshop on 14.03. we decided to go for the following implementation: |
The work around, i.e. adding intermediate observations, is indeed the best way to model with this configuration. This is similar to what SOSA does for example. However, another alternative is to not model Speed as an instance but as a property. And this would generalize for all vehicle properties (static and dynamic). Again, what was the rationale to model a class hierarchy instead of a property hierarchy? I need a refresh! |
I wouldn't call it a work around. As discussed in the workshop, it seems to make sense for dynamic vehicle properties to model it like that, as they're mostly used in combination with observations. Punning was suggested for having both instances and classes or properties available.
for some static properties it makes sense, to instantiate (e.g. model, brand, etc.) as there the connections help. For the dynamic part the reason was (if I recall correctly, have to check notes) the proximity to SOSA. |
@rtroncy , do you mean having a property hierarchy like:
In that case, we would have something like:
I think the main reason of having them as clases was being able to create instances and to tell something else about the clases. For example, to specify to which vehicle component is that property related or to keep open the option to specify further a hierarchy of vehicle brands and models, etc. |
@jdacoello You could probably get rid of the blank nodes. The value of the property will make use of The added value is that the model is much simpler to query (and to understand, thus to adopt). The cons is that indeed, you're not following the SOSA modeling as @danielwilms said. What does this mean that |
@rtroncy The approach with property hierarchies you are proposing will probably not work as expected as the OWL datatype properties are limited to have a literal value only and not a physical unit. Furthermore in conjunction with issue #29 we would like to attach additional metadata like minimum, maximum value to properties. If we follow the approach depicted in the diagram of @jdacoello under the headline "workaround" we will have a clean model. |
@felix-loesch No, this is not true. See the extension with custom datatypes, with |
You don't need the There's the proposal of punning on the table as well, which could help, but make it more complex. |
We have already thought many times about the best approach to handle the different requirements for static and dynamic vehicle properties. We came to the following conclusions:
|
@rtroncy I like the simplicity of expressing units in this compacted way. Since we want to promote the adoption of VSSo, I suggest sticking with a solution that uses the default datatypes. And handling the units with instances of an already existing ontology. |
+1. The tooling issue is really important for adoption of VSSo. |
Next Step: |
True, standard OWL reasoners won't be able to tell that |
@felix-loesch For static properties, however, I don't understand why datatype properties were deemed inappropriate.
I don't get how the 2nd sentence follows from the 1st one. |
* previously DVPs were modeled as subclasses, now changed according to: w3c/vsso#22 * changed rdfs:comment to skos:definition for better fit * adding comments to rdfs:comment instead
* Dynamic Vehicle Properties (DVP) changed to instances * previously DVPs were modeled as subclasses, now changed according to: w3c/vsso#22 * changed rdfs:comment to skos:definition for better fit * adding comments to rdfs:comment instead * Using new annotation property for dot notation Previously we used `skos:altLabel`. Took over suggestion from Alan Freedman using vsso-core:vssFacetedClassification instead. Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de>
Currently the VehicleComponents were modelled as subclasses with `rdfs:subclass`. This change introduces a variable to choose either way until it's decided. Additionally introduced documentation improvements and code cleanups. Mentioned in: w3c/vsso#22 Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de>
* VSSo: VehicleComponents as instances Currently the VehicleComponents were modelled as subclasses with `rdfs:subclass`. This change introduces a variable to choose either way until it's decided. Additionally introduced documentation improvements and code cleanups. Mentioned in: w3c/vsso#22 Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de> * Adding `vsso:Vehicle` as an instance of `vsso-core:VehicleComponent` Change reflecting discussion in: w3c/vsso#41 (comment) Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de>
ONLY if the proposal to issue #13 is accepted, consider changing specific The resulting structure would look like the following figure for the example of the vehicle's |
@danielwilms to create counter proposal |
I wish to also make a counter proposal based on the idea sketched in #22 (comment), using ucum datatype and RDF-star for attaching temporal information to the observations. I could prepare such a proposal by mid/end-July. Would it be to late? |
@rtroncy Any other proposal is always welcome. The next meeting will be on Monday 11.07.2022. I believe that this topic will be further discussed there. Maybe by then it would not be resolved yet. But, since the discussion is fresh, it would be great if you could join the call and bring also your ideas as these aspects have a direct impact on the core model. FYI, it was mentioned in the last meeting that for some static vehicle properties (i.e., attributes) it will make more sense to have data properties directly linked to a Vehicle. The main idea behind my last proposal was to be generic. Apparently, the proposal (detailed in issue #13) has is a better fit for a DynamicVehicleProperty only. |
In the current proposal, concepts generated from VSS are sub-classes of the core ontology, rather than instances. In this issue we want to collect pros and cons as preparation for a decision.
The text was updated successfully, but these errors were encountered: