VSSo: VehicleComponents as instances #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the VehicleComponents were modelled as subclasses with `rdfs:subclass`. This change introduces a variable to choose either way until it's decided. Additionally introduced documentation improvements and code cleanups. Mentioned in: w3c/vsso#22 Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de>
erikbosch
reviewed
Jun 13, 2022
| # subclasses of vehicle components. False means that branches are handled | ||
| # as instances of vehicle components. | ||
|
|
||
| COMPONENTS_AS_CLASSES = False |
There was a problem hiding this comment.
What do we see as possible time range for keeping both options. If we intend to keep both for a long period, then we should maybe think about adapting CI so that we test both options, to make sure that we do not introduce regressions in any of them.
There was a problem hiding this comment.
It's just for now, to avoid jumping from one commit to the other. It should be decided in the next couple of weeks.
Change reflecting discussion in: w3c/vsso#41 (comment) Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de>
|
decision to merge 2022/06/14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the VehicleComponents were modelled as
subclasses with
rdfs:subclass. This change introducesa variable to choose either way until it's decided.
Additionally introduced documentation improvements and
code cleanups.
Mentioned in: w3c/vsso#22
Signed-off-by: Daniel Wilms Daniel.DW.Wilms@bmw.de