[vsso-core] Fixes ObservableVehicleProperty #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielwilms
force-pushed
the
#19-ovp-fix
branch
from
eb4cb83 to
6f50504
Compare
As stated in w3c#19 the metadata of ObservableVehicleProperty was incorrect: * referred to VSS `actuator` instead of `sensor` * `seeAlso` link was broken * `StaticVehicleProperty` defined as in VSS * Text in `DynamicVehicleProperty` adapted as well This commit fixes it. Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de>
danielwilms
force-pushed
the
#19-ovp-fix
branch
from
6f50504 to
9cab9c4
Compare
Before the links didn't work correctly. This commit fixes it. Signed-off-by: Daniel Wilms <Daniel.DW.Wilms@bmw.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in #19 the metadata of ObservableVehicleProperty was incorrect:
actuatorinstead ofsensorseeAlsolink was brokenThis commit fixes it. Some changes are due to the generated code. Once #18 is fixed, no need to check it in.
Signed-off-by: Daniel Wilms Daniel.DW.Wilms@bmw.de