fix font awesome icons width #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivienlacourba
approved these changes
Oct 16, 2023
NicolaSaunders
approved these changes
Oct 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently migrated to font awesome 6 which changed the way the default width was set. They now use
font-sizeto manage the specify size of the icons where the version 5 usedwidth.The side effect is that our default icon svg size is set to 100% and the font awesome bootstrap no longer overrides that value resulting is weird alignment:
instead of
That PR removes the 100% width for svg from font awesome.
Fix w3c/w3c-website#528