-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beta: Broken-looking 'g' and 't' characters in font #29
Comments
Issue is still present in the latest beta https://beta.w3.org/ (note the lowercase |
@vivienlacourba I believe you're right, that this issue and #290 are related. I am definitely not an expert when it comes to the intricacies of fonts - I had to search for what hinting meant! Please @patrickhlauke correct me if I am wrong with any of the following:
|
@NicolaSaunders I'll admit that I don't know the exact cause, nor solution, to this. just a hunch on my part that the weirdness is somehow related to some of the underlying metrics inside whichever font has been used :D |
Thanks! I think we should give this a go, and if it doesn't resolve it then we can raise it as an issue (and consider bumping up the font size in buttons). |
@NicolaSaunders @patrickhlauke before we implement this change let me ping our Web Fonts expert @svgeesus to ask for his feedback on this issue. |
What tool was used to create the woff versions of the original fonts? |
That seems likely. But woff can contain the hinting information.
No, just recreate the woff fonts with hinting. |
Thanks @svgeesus I believe the tool used to create the woff versions was the Google Webfonts Helper Can I please check, to recreate the woff fonts in the best way, should we download the latest version of Noto Sans and run the hinted (TTF) files through a tool such as the Font Squirrel webfont generator? |
I have regenerated the font files in the branch hotfix/update-webfont. |
@patrickhlauke I just deployed @NicolaSaunders's fix. Can you check if that fixes the issue? |
@deniak deployed on beta.w3.org you mean? if so sure, I can have a quick check in a minute |
Yes, the new fonts have been deployed |
Looking at the beta site just now, I still see the same as before Looking closer at the So this is really just the Incidentally, I'd be interested to hear if anybody else is seeing the weirdly squished |
@patrickhlauke do you have the same issue with other browsers? |
@deniak sorry, should have added: it does look correct now in Firefox/Windows So it's just a Chrome/Windows issue for me at the moment (or, to be more accurate, Chromium ... I see the same broken |
Yes, as mentioned in the OP, I see it correctly on Chrome/macOS, so this seems a Chrome/Windows-specific quirk |
Thanks for the details, I'll try to get my hands on a more recent windows machine to try to reproduce the issue. |
I believe the WAI site uses the same Noto Sans font. Just out of curiosity @patrickhlauke would you mind having a look to see how the font display compares there? |
checking the WAI site (and modifying one of their buttons to include the letter (also note on the WAI site that the lowercase |
Thanks. That's interesting - I think we should compare the styles/metrics across these two sites to see if this can be resolved with CSS. |
Happy to report that when I look at the (now launched) site https://www.w3.org/ the |
Not sure if it's due to some slightly broken hinting or similar, but the lowercase 'g' looks rather odd on the design system site at least on Windows (but correct on macOS).
Chrome/Windows
Firefox/Windows
Note that once you zoom in, the look of the 'g' sorts itself out, which is why I'm thinking it's some bad hinting.
EDIT: just noticed similar issue with the lowercase 't' as well
The text was updated successfully, but these errors were encountered: