Fixed skipto bug with Safari on rendering menu item with focus #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in safari rendering the menu item with focus
✅ Deploy Preview for wai-aria-practices2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Closed
|
Ok, I will put into the ARIA practices repo. |
|
Made change to aria-practices repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed from
overflow-y:autotooverflow-y:clipin CSS string to fix a bug in Safari rendering the menu item with focus for SkipTo.There must have been a recent update to the CSS engine in Safari to introduce this bug, since I didn't see it a few weeks ago. Just saw it this morning, seems to be a simple fix.