Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON file references wrong wcag version #142

Closed
minordemon opened this issue Dec 28, 2023 · 2 comments
Closed

JSON file references wrong wcag version #142

minordemon opened this issue Dec 28, 2023 · 2 comments
Assignees

Comments

@minordemon
Copy link

When I select WCAG2.1 and save the report as JSON 'auditSample / test / id' references the WCAG2.0 id. 'WCAG20:text-equiv-all' instead of 'WCAG21:non-text-content'.

To Reproduce
Steps to reproduce the behavior:

  1. Either import the included JSON file, or create a new report and fill in one 'observation' and 'WCAG 2.1' or 'WCAG 2.2'
  2. Download Report (JSON)
  3. Check JSON file. (find your comment and check the id)

Expected behavior
The id should be from the chosen WCAG version.

JSON excerpt

{
    "type": "Assertion",
    "date": "2023-12-28T13:01:14.981Z",
    "mode": { "type": "TestMode", "@value": "earl:manual" },
    "result": {
    "type": "TestResult",
    "date": "2023-12-28T12:56:11.607Z",
    "description": "**This should be: Non-text Content wcag2.1**",
    "outcome": {
        "id": "earl:failed",
        "type": ["OutcomeValue", "Fail"],
        "title": "Failed"
    }
    },
    "subject": {
    "id": "_:subject_1",
    "type": ["TestSubject", "Website"],
    "date": "2023-12-28T12:54:52.420Z",
    "description": "",
    "title": "Test"
    },
    "test": {
    "id": "WCAG20:text-equiv-all",
    "type": ["TestCriterion", "TestRequirement"],
    "date": "2023-12-28T12:54:52.421Z"
    }
},

Desktop (please complete the following information):

  • OS: MacOS
  • Browser Firefox
  • Version 121.0
  • report tool 3.0.3 (23 dec 2023)

Additional context

Test file:
test-evaluation.json

@BartCardan
Copy link

I am experiencing the same issue.
Please make sure the id is correct for the corresponding version.

As ids are changed at this moment other systems relying on the JSON need new mapping.

@iadawn iadawn self-assigned this Jan 2, 2024
mhansma96 added a commit to mhansma96/wai-wcag-em-report-tool that referenced this issue Jan 8, 2024
mhansma96 added a commit to mhansma96/wai-wcag-em-report-tool that referenced this issue Jan 9, 2024
mhansma96 added a commit to mhansma96/wai-wcag-em-report-tool that referenced this issue Jan 9, 2024
iadawn added a commit that referenced this issue Jan 9, 2024
#142 Potential fix for criteria mapping issue
@iadawn
Copy link
Contributor

iadawn commented Jan 9, 2024

@minordemon Thanks for the spot, should be addressed with latest release. If there are any problems, please reopen this issue and we will take another look at things.

Huge thanks to @mhansma96 for the fix

@iadawn iadawn closed this as completed Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants