Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ready for review] Polish translation #146

Merged
merged 24 commits into from
Jun 18, 2024
Merged

[Ready for review] Polish translation #146

merged 24 commits into from
Jun 18, 2024

Conversation

zwiastunsw
Copy link
Contributor

@zwiastunsw zwiastunsw commented Jan 16, 2024 •
edited
Loading

I added folder /locales/pl with polish translation files
I modified file scripts/i18n.js

related w3c/wai-translations#162

@remibetin remibetin linked an issue Jan 16, 2024 that may be closed by this pull request
[Polish] [WCAG-EM Report Tool] w3c/wai-translations#162
Closed
remibetin
remibetin requested changes Feb 13, 2024
View reviewed changes
Copy link
Member

@remibetin remibetin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zwiastunsw I have added some minor technical comments.

Please also point to the original WCAG-EM Working Group Note in the links.

src/locales/pl/PAGES/SCOPE.json Outdated Show resolved Hide resolved
src/locales/pl/PAGES/SCOPE.json Outdated Show resolved Hide resolved
src/locales/pl/PAGES/SCOPE.json Outdated Show resolved Hide resolved
@remibetin remibetin changed the title Polish translation [Ready for review] Polish translation Feb 13, 2024
@remibetin remibetin mentioned this pull request Feb 13, 2024
Closed
humanthing-ltd
humanthing-ltd reviewed Feb 26, 2024
View reviewed changes
Copy link
Contributor

@humanthing-ltd humanthing-ltd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a number of small suggestions, introducing a more gender-neutral approach to references to gender-specific roles used throughout the tool. Additonally, I simplified some of the language.

zwiastunsw and others added 3 commits February 28, 2024 01:57
@zwiastunsw @humanthing-ltd
Update src/locales/pl/PAGES/EXPLORE.json
7595ca7 
Co-authored-by: Human Thing Ltd <113432222+humanthing-ltd@users.noreply.github.com>
@zwiastunsw @humanthing-ltd
Update src/locales/pl/PAGES/EXPLORE.json
bc0f56c 
Co-authored-by: Human Thing Ltd <113432222+humanthing-ltd@users.noreply.github.com>
@zwiastunsw @humanthing-ltd
Update src/locales/pl/PAGES/SAMPLE.json
9d07bd4 
Co-authored-by: Human Thing Ltd <113432222+humanthing-ltd@users.noreply.github.com>
zwiastunsw and others added 9 commits February 28, 2024 01:59
@zwiastunsw @humanthing-ltd
Update src/locales/pl/PAGES/SUMMARY.json
4db0388 
Co-authored-by: Human Thing Ltd <113432222+humanthing-ltd@users.noreply.github.com>
@zwiastunsw @humanthing-ltd
Update src/locales/pl/UI/REPORT.json
8be7797 
Co-authored-by: Human Thing Ltd <113432222+humanthing-ltd@users.noreply.github.com>
@zwiastunsw @humanthing-ltd
Update src/locales/pl/UI/NAV.json
506ad37 
Co-authored-by: Human Thing Ltd <113432222+humanthing-ltd@users.noreply.github.com>
@zwiastunsw @humanthing-ltd
Update src/locales/pl/PAGES/SUMMARY.json
b333c42 
Co-authored-by: Human Thing Ltd <113432222+humanthing-ltd@users.noreply.github.com>
@zwiastunsw @humanthing-ltd
Update src/locales/pl/PAGES/SCOPE.json
e8b27ae 
Co-authored-by: Human Thing Ltd <113432222+humanthing-ltd@users.noreply.github.com>
@zwiastunsw @humanthing-ltd
Update src/locales/pl/PAGES/SCOPE.json
da53d5e 
Co-authored-by: Human Thing Ltd <113432222+humanthing-ltd@users.noreply.github.com>
@zwiastunsw @humanthing-ltd
Update src/locales/pl/PAGES/START.json
2036440 
Co-authored-by: Human Thing Ltd <113432222+humanthing-ltd@users.noreply.github.com>
@zwiastunsw @humanthing-ltd
Update src/locales/pl/PAGES/START.json
54cff13 
Co-authored-by: Human Thing Ltd <113432222+humanthing-ltd@users.noreply.github.com>
@zwiastunsw @humanthing-ltd
Update src/locales/pl/PAGES/START.json
db36174 
Co-authored-by: Human Thing Ltd <113432222+humanthing-ltd@users.noreply.github.com>
@remibetin
Copy link
Member

Hi @zwiastunsw

Have you taken a look at my comments? #146 (review)

Let me know if you have questions.

remibetin
remibetin requested changes Mar 5, 2024
View reviewed changes
Copy link
Member

@remibetin remibetin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zwiastunsw Thanks for the edits!

The only remaining thing before we can publish: please refer to the original WCAG-EM Working Group Note in the links.

@remibetin remibetin self-requested a review March 5, 2024 13:55
remibetin
remibetin requested changes Mar 5, 2024
View reviewed changes
src/locales/pl/PAGES/EXPLORE.json Outdated Show resolved Hide resolved
src/locales/pl/PAGES/SCOPE.json Outdated Show resolved Hide resolved
remibetin
remibetin requested changes Mar 5, 2024
View reviewed changes
src/locales/pl/PAGES/EXPLORE.json Outdated Show resolved Hide resolved
@remibetin remibetin self-requested a review March 5, 2024 15:29
@remibetin remibetin self-assigned this Mar 5, 2024
@zwiastunsw zwiastunsw mentioned this pull request Apr 8, 2024
Closed
@zwiastunsw
Copy link
Contributor Author

@remibetin This resource is ready to publish. Does anything else need to be done?

@zwiastunsw
Copy link
Contributor Author

@remibetin: Is there any reason that this PR has not been closed yet?

@remibetin
Copy link
Member

Hi @zwiastunsw Sorry for the delay. I remember having found issues with the tool the last time I checked. I will check again and let you know the next steps.

@remibetin remibetin merged commit a35f990 into w3c:main Jun 18, 2024
3 checks passed
@remibetin
Copy link
Member

This translation has been published today 🚀 Thank you for your contribution and patience @zwiastunsw @humanthing-ltd!

See https://www.w3.org/WAI/eval/report-tool/

Your contribution is acknowledged at https://www.w3.org/WAI/eval/report-tool/acknowledgements & https://www.w3.org/WAI/translations/#polski-polish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remibetin remibetin remibetin approved these changes

@humanthing-ltd humanthing-ltd Awaiting requested review from humanthing-ltd

Assignees

@remibetin remibetin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Polish] [WCAG-EM Report Tool]
3 participants
@zwiastunsw @remibetin @humanthing-ltd