-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
G183: Removing hover/focus steps from procedure #1553
Conversation
So this PR means that it is now OK to have a hardly visible link that even does not change on hover/focus… I guess that is only consequential from PR #1500 and the discussion around using this, but it is still disappointing to me. |
There are two necessary reasons for this:
So yes, it is possible to create very difficult examples, but the opposite is also true so the metric is not enough to make it binding. |
What was the state of this? Will it be merged, or does it need further discussion? |
@alastc so now that you've added the step back in ... are we saying that the 3:1 ratio is not sufficient? "For this technique, other visual highlights are also required" so does it pass or not without the extra highlighting? this is now contradictory |
techniques/general/G183.html
Outdated
@@ -28,11 +32,12 @@ <h3>Colors that would provide 3:1 contrast with black words and 4.5:1 contrast w | |||
<ol> | |||
<li>Locate all instances where color alone is used to convey information about text.</li> | |||
<li>Check that the <a>relative luminance</a> of the color of the text differs from the relative luminance of the surrounding text by a contrast ratio of at least 3:1.</li> | |||
<li>Check that pointing (mouseover) to the link causes a visual enhancement (such as an underline, font change, etc.)</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"pointing (mouseover) to the link" ... why not hovering? don't think anybody does anything explicitly on mouseover
from a JS perspective, it's usually :hover
from CSS
if it's more a case of providing an additional cue as a technique that goes beyond the normative requirement, then i'd suggest not using the word "required" in the phrase there. instead, making it clear that although the 3:1 ratio is sufficient to pass the minimum requirement of use of color, this technique suggests adding an additional highlight/cue that goes beyond the normative requirement, for increased usability |
👍 |
Super concerned about adding back Consider removing |
agree with @yatil this should be an advisory technique. not a sufficient technique. the sufficient part is the 3:1 contrast, the rest is window dressing. may also be good to add a note explicitly clarifying that while this will be of benefit to mouse users, it won't help on touchscreen or stylus devices where there is no concept of hover (well, the vast majority of stylus devices ... some fancy ones do have hover stylus support, like Samsung Note ones) |
techniques/general/G183.html
Outdated
@@ -29,16 +31,13 @@ <h3>Colors that would provide 3:1 contrast with black words and 4.5:1 contrast w | |||
<section class="procedure"><h3>Procedure</h3> | |||
<ol> | |||
<li>Locate all instances where color alone is used to convey information about text.</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the hover part does go beyond WCAG so we need to keep that "beyond" aspect in. |
incorporating a refernce to focus change
@alastc I've added in a modification which I think addresses my concern. I didn't put in a link to 2.4.7, as I wasn't sure on the syntax. |
@yatil and @patrickhlauke, we discussed this in the meeting, and there's a key point that sufficient techniques can go beyond the minimum requirements. The description now includes:
We also discussed removing the technique entirely, but decided not to as it helps to have sufficient techniques, and this one in particular helped the SC overcome objections originally. |
ah, shamefully i have to admit i was unaware of the exact definition of advisory techniques (that, in essence, they may not even address the actual ask of an SC). somehow got it in my head that advisory was "sufficient to pass the SC, plus something extra on top of that". so i can see how this is a sufficient technique, but not strictly the "minimum sufficient technique" as it incorporates extra stuff. long way of saying yup, agree (now that i delved into the actual definitions of advisory vs sufficient) |
Sometimes I just wished we would use words in a way that they are used commonly outside of our accessibility bubble where sufficient does not mean going beyond. This conflating of meaning is a constant struggle, especially for people learning to differentiate between best practices and absolute requirements. Having Pass/Fail requirements but muddying the water in examples does not really help learning. |
Closes #1272
Related to #201