Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "tablets...mobile devices" to a better structure without suggesting tablets AREN'T mobile devices #3776

Merged
merged 5 commits into from
Nov 19, 2024

Conversation

patrickhlauke
Copy link
Member

@patrickhlauke patrickhlauke commented Apr 5, 2024

This removes the weird ambiguity of "why list tablets separately from mobile devices" and closes #3750


Preview | Diff

This removes the weird ambiguity of "why list tablets separately from mobile devices" and closes #3750
@bruce-usab
Copy link
Contributor

Discussed on TF call 4/12. There was not support for the change. Suggestion was made to address via Proposed response, and not a PR.

@patrickhlauke
Copy link
Member Author

patrickhlauke commented May 4, 2024

I'd still put my case forward for this. In the discussion that led to it, we seemed to agree that "mobile devices" is a loaded term - some people see it as encompassing all sorts of mobile devices (smartphones, tablets, phablets, arguably even laptops), in which case it then looks odd to make an apparent distinction between "mobile devices, and tablets"; others see mobile devices as meaning purely phones, and therefore name-checking "tablets" separately makes sense.

To satisfy both groups, the simplest way is to just avoid the loaded term "mobile devices" and to explicitly say "smartphones and tablets". Don't think anything is lost here by abandoning the ambiguous group term in favour of the actual device classes themselves.

But yes, it's a very low priority/importance thing. Mainly, it just reads odd to people. Either way, let's make a decision on this and move on, so this doesn't hang around gumming up effort that should be spent elsewhere.

guidelines/index.html Outdated Show resolved Hide resolved
Co-authored-by: Mike Gower <mikegower@gmail.com>
guidelines/index.html Outdated Show resolved Hide resolved
incorporating various suggestions from users into one new change
@mbgower mbgower added Editorial ErratumRaised Potential erratum for a Recommendation labels May 28, 2024
@mgifford
Copy link

But this patch didn't actually remove the term mobile devices. Why is this proposed in the patch:

    These guidelines address accessibility of web content on any kind of device (including desktops, laptops, kiosks, and mobile devices)

And not something like:

    These guidelines address accessibility of web content on any kind of device (including desktops, laptops, kiosks, tablets and smartphones).

Unless I'm missing something here in the patch. And yes, I did add back in tablets.  Might as well.

@patrickhlauke
Copy link
Member Author

@mgifford you're missing that after my initial change, the PR was further munged and turned around :) will update actual title for clarity

@patrickhlauke patrickhlauke changed the title Change "mobile devices" to "smartphones" Change "tablets...mobile devices" to a better structure without suggesting tablets AREN'T mobile devices May 31, 2024
@@ -13,7 +13,7 @@
</head>
<body>
<section id="abstract">
<p>Web Content Accessibility Guidelines (WCAG) 2.2 covers a wide range of recommendations for making Web content more accessible. Following these guidelines will make content more accessible to a wider range of people with disabilities, including accommodations for blindness and low vision, deafness and hearing loss, limited movement, speech disabilities, photosensitivity, and combinations of these, and some accommodation for learning disabilities and cognitive limitations; but will not address every user need for people with these disabilities. These guidelines address accessibility of web content on desktops, laptops, tablets, and mobile devices. Following these guidelines will also often make Web content more usable to users in general.</p>
<p>Web Content Accessibility Guidelines (WCAG) 2.2 covers a wide range of recommendations for making Web content more accessible. Following these guidelines will make content more accessible to a wider range of people with disabilities, including accommodations for blindness and low vision, deafness and hearing loss, limited movement, speech disabilities, photosensitivity, and combinations of these, and some accommodation for learning disabilities and cognitive limitations; but will not address every user need for people with these disabilities. These guidelines address accessibility of web content on any kind of device (including desktops, laptops, kiosks, and mobile devices). Following these guidelines will also often make Web content more usable to users in general.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this needs to be in brackets:

Suggested change
<p>Web Content Accessibility Guidelines (WCAG) 2.2 covers a wide range of recommendations for making Web content more accessible. Following these guidelines will make content more accessible to a wider range of people with disabilities, including accommodations for blindness and low vision, deafness and hearing loss, limited movement, speech disabilities, photosensitivity, and combinations of these, and some accommodation for learning disabilities and cognitive limitations; but will not address every user need for people with these disabilities. These guidelines address accessibility of web content on any kind of device (including desktops, laptops, kiosks, and mobile devices). Following these guidelines will also often make Web content more usable to users in general.</p>
<p>Web Content Accessibility Guidelines (WCAG) 2.2 covers a wide range of recommendations for making Web content more accessible. Following these guidelines will make content more accessible to a wider range of people with disabilities, including accommodations for blindness and low vision, deafness and hearing loss, limited movement, speech disabilities, photosensitivity, and combinations of these, and some accommodation for learning disabilities and cognitive limitations; but will not address every user need for people with these disabilities. These guidelines address accessibility of web content on any kind of device including desktops, laptops, kiosks, and mobile devices. Following these guidelines will also often make Web content more usable to users in general.</p>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there needs to be something after the "any kind of device" to give that appropriate emphasis. If it wasn't a bracket, I think we'd end up with: "on any kind of device; including desktops", which is slightly less obvious. I don't have a strong opinion either way, it doesn't seem like a big issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I can live with that. I did want to have a response from the group though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at the very least i think a comma would be good, or a dash. but i can live with no separator at all.

I'm actually more concerned now, re-reading this, with the awkward ; but will not ... earlier in that paragraph. it reads super clunky.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WilcoFiers the intent was to make it clearer that the guidelines cover web content on any device, hence the use of the parentheses to demarcate that a bit more clearly and emphasize that the parenthetical items were examples, not an exhaustive list (which was one of the concerns in some of the discussions).

Are you arguing that the use of parentheses actually changes the meaning, as opposed to the use of commas? If not, since the current wording was adopted through a full review by the working group last spring, I'm inclined to leave it as is.

Copy link
Contributor

@mbgower mbgower Nov 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually more concerned now, re-reading this, with the awkward ; but will not ... earlier in that paragraph. it reads super clunky.

@patrickhlauke this is pre-existing language and was not raised as part of the original issue. I also think it's not a great use of a semicolon, but that is not part of the change in this PR, and so is scope creep.

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for wcag2 ready!

Name Link
🔨 Latest commit 0f32666
🔍 Latest deploy log https://app.netlify.com/sites/wcag2/deploys/673cc27ead46c400087c8769
😎 Deploy Preview https://deploy-preview-3776--wcag2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kfranqueiro kfranqueiro merged commit 378d4bf into main Nov 19, 2024
5 checks passed
@kfranqueiro kfranqueiro deleted the patrickhlauke-issue3750 branch November 19, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editorial ErratumRaised Potential erratum for a Recommendation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WCAG Abstract section makes distinction between "tablets" and "mobile devices"
9 participants