Harmonise wording for techniques checks/steps

[patrickhlauke]

Currently, techniques use a mix of wording If step X... and If check X..., as well as a few outlier "If test procedure X...". Most prefix the step/check number with #, but some don't. And conceptually, I think it makes more sense saying that a check is true/false, rather than a step being true/false.

This PR tries to harmonise this, settling for check and adding missing # (though, it has to be said, this use of the octothorpe is a bit US-centric, so maybe we want to harmonise to not having it?)

[fstrr]

Agree on the US-centric use of the # symbol. I've often considered yoinking it out and would be fine with it being removed.

[patrickhlauke]

Point to discuss in our next WCAG 2.x meeting then ... if we want to yoink # out, I can do a big find/replace and add it as a commit here.

[alastc]

I think aligning with the earlier examples is probably best (and the least amount of files changed), which is what you've done. That will also ruffle the least feathers.

[ljoakley]

completed with a few changes

[mbgower]

@shawna-slh Is there any style decision on use of the pound symbol (#) in front of ordered list references?

[shawna-slh]

Thanks for the ping @mbgower ! We don't currently have that in our Style guide. (I prefer without the # - yet don't have any support for or against that. update: I've noticed myself sometimes wanting to use "#" in such cases.) From a quick search, I don't find guidance in leading Style Guides -- so it needs more research.

The good news is we have a new WAI staff person coming on the end of the month who will be great at citing sources for a decision.

Are y'all comfortable leaving this issue open for a few weeks until we can get back to it?

(p.s. thanks to @patrickhlauke I learned a new term, "octothorpe".)

[patrickhlauke]

Are y'all comfortable leaving this issue open for a few weeks until we can get back to it?

no rush from my perspective. I'd rather wait and then do all the changes in a oner, once we have a decision on the #

[mbgower]

@shawna-slh Sorry, I missed those final comments when I brought this into our current review cycle.
If someone gets to this by the start of August, we can just incorporate your change, otherwise we'll just push a second update when you make your recommendation.

[shawna-slh]

@tamsinewing555 will probably get to it within a few days :)

[netlify]

✅ Deploy Preview for wcag2 ready!

Name	Link
🔨 Latest commit	551193b
🔍 Latest deploy log	https://app.netlify.com/sites/wcag2/deploys/66b3f34ad654da000892557c
😎 Deploy Preview	https://deploy-preview-3915--wcag2.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.