Instructions paragraph cleanup #3941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kfranqueiro marked as non substantive for IPR from ash-nazg. |
kfranqueiro
force-pushed
the
kgf-instructions-cleanup
branch
from
fc7771e
to
a4b74cc
Compare
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
These paragraphs are automatically generated by the build process, and should not be manually added to source files. In the case of ARIA24, the build will automatically generate a more descriptive paragraph for ARIA techniques than the one being removed.
(These paragraphs would be pruned by the build process, but shouldn't be)
kfranqueiro
force-pushed
the
kgf-instructions-cleanup
branch
from
a4b74cc
to
08fdff6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3918.
There are multiple commits in this PR, each grouping a subset of removals:
<p class="instructions">paragraphs having no effect on outputlabel-in-name.htmlthat did not even haveclass="instructions", and was thus already causing repetition of auto-generated content.)class="instructions"from paragraphs with custom content that should not have had this class; these were previously absent from build output but will now be present.In cases where removal of these paragraphs clearly yielded an empty section, I have removed the entire section. (In some cases, these sections were already commented out.) This overlaps a bit with #3927; I have updated the log there to exclude what's already handled in this PR.
Note: as part of this PR, I have removed
identify-changes.htmlandinterruptions-minimum.htmlfromunderstanding/21, as both of these seemed to be unused and largely contained template boilerplate. These removals do not affect build output at all.