-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eleventy build: Support generating WCAG 2.1 docs from main branch #4007
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kfranqueiro marked as non substantive for IPR from ash-nazg. |
I'm fairly sure we didn't include anything 2.2 specific in 2.1 docs without that markup, it was very rare. |
0572cda
to
b5a5efc
Compare
b5a5efc
to
46efadf
Compare
1c010a2
to
6873aef
Compare
d6bfbc5
to
b645c53
Compare
94cc984
to
e1e813e
Compare
Also update other docs metadata in understanding.ts to match
1f74470
to
312c92a
Compare
@mbgower - use of color, contrast (minimum), resize text |
Discussed on backlog call 11-1 and review divided up (as above). |
@kfranqueiro, the files for changed understanding docs (for instance use-of-color) are not generally showing up in the Files changed tab's list; however, I have confirmed that modifications to notes and the addition of paragraphs from 2.2 have been incorporated into the 2.1 preview (e.g., where the note or paragraph is missing from the current 2.1 Understanding doc). |
@kfranqueiro while the contrast minimum material has been updated, I assume the double-square bracket references in all 3 versions of this understanding document (2.0, 2.1, 2.2) were intended to be linked references, but did not generate properly. It looks like this is covered by #2535 so just flagging again here. |
Right, the actual source files for informative docs won't change. The difference is this builds 2.1 docs from
Right, this doesn't affect that, and those have been an issue for as long as these docs have existed in their current form; there's a separate PR I opened this Tuesday that addresses as much of that as can currently be addressed with the information available in specref and our local biblio.js. |
@kfranqueiro I am now reviewing understanding/conformance. IMO, for both 2.2 and 2.1, "which includes techniques for providing Conforming Alternate Version" should be lower case, to read:
The rationale is that the definition itself (2 paragraphs earlier) is lower case, so while it is fine to leave the heading link in camel case, the final term should be lc. I'm also trying to understand whether "conforming alternative version" and "conforming alternate version" are accidental differences, or if there are actually two different terms. There are 31 occurrences of the former and 5 of the latter. I'm 90% sure this is supposed to all be the same thing; you'll note that under the title "Understanding Conforming Alternate Versions" both terms are used in the next paragraph, seemingly as synonyms. IMO, these should all be alternative. That means "another option", while alternate implies a vacillation between two options. I just had a look at WCAG 2.2, and its use of the two terms is almost opposite that in the Understanding section: 52 occurrences of "alternative" and 14 of "alternate"; however, there continues to be, within the normative text, use of the term "conforming alternate version" including in a definition. @alastc do we just leave all these conflicts in place in the normative text, or do we try to incorporate this into the CFC? PS When I just checked various files, I seemed to come up with different counts (48, 25). I'm not sure if I was doing a search with match case last time or what |
@kfranqueiro |
@kfranqueiro potentially the same issue in the Technical Definition of "Accessibility Supported" section; however, it is also like this on the 2.2 version, so maybe this is intentional?! IMO, since there is styling showing the WHOLE thing is a quote, the quotation marks in front of note are not correct. |
The open quote issue appears to be a pre-existing issue in CSS. Both the open quote and alternative/alternate issues should be entered as separate issues so we don't lose track of them, as they aren't specifically consequences of this PR. Update: blockquote CSS issue entered at #4134 |
The canonical term, since 2008 is conforming alternate version. There is nothing wrong with "alternative" elsewhere -- but we should avoid it between "conforming" and "version". I find one (and only one) use of "conforming alternative version" in the spec, in Note 5. We should correct that for the CFC. It is editorial. |
@kfranqueiro an additional case of odd quotations marks on the Conformance page, this time appearing alone on the last lines |
In addition to completing my review of the three assigned files, I have also now completed the penultimate Conformance topic, and marked it as complete. |
Despite me beginning to note a number of inconsistencies in the pre-existing content, that is not the purpose of this PR. It is to unearth issues with the migration of 2.2 changes to 2.1 content. I have opened up a new issue to track this #4135 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed my 3 assigned files. Didn't notice any issues (good catch on the pointer-gestures reference to dragging motion) except for one note/question on the slug override functionality for target-size-enhanced vs target-size
assertIsWcagVersion(version); | ||
return scSlugOverrides[fileSlug](version); | ||
} | ||
return fileSlug; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If someone somehow tries to visit the non-overriden slug, this is still going to resolve it; if I try that for target-size-enhanced
in your test branch (ie, https://kfranqueiro.github.io/wcag/understanding/target-size-enhanced ), it resolves, but the resulting page is mistitled using the 2.2 title instead of the 2.1 title. Perhaps better to prevent it from resolving?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a detailed look at this. The -enhanced
page you are seeing is a remnant from what was already on the gh-pages
branch that this published over; when running a clean build with WCAG_VERSION=21
, only target-size.html
is produced.
$ ls _site/understanding/target-size*
_site/understanding/target-size.html
The way that scSlugOverrides
works is that each input file's basename (i.e. target-size-enhanced
) gets looked up, and if a function for that name is found, the output of the function is used as the output basename instead. This results in target-size-enhanced
being mapped (or "moved") to target-size
specifically for WCAG < 2.2; there is no "fallback".
WRT Parsing 4.1.1, @kfranqueiro asks:
No, I think what you have is fine. I even considered the case of the 2018 2.1 edition, and if a different note (or Understanding doc) is needed. Again, what you have is fine. Thank you! |
Understanding Techniques 2.1 has |
@bruce-usab that is a known issue (#2953) found widely across existing WCAG 2.1 pages like the one you linked. Building with this PR fixes that. (See the example of the same page built with this PR: https://kfranqueiro.github.io/wcag/understanding/understanding-techniques) |
@kfranqueiro, the decision you have made in the final section on referring to WCAG from other documetns is a bit novel, and I think needs a bit more consideration/confirmation.
Looking exclusively at what has been done in 2.2, we have moved to generic usage of "WCAG 2" unless a specific version is required. That is, in the lastest document, there are 27 occurrences of the term "WCAG 2" and only 7 occurrences of the term "WCAG 2.2". I am inserting a very scaled-down version to provide some visual context of where these specific uses of 2.2 occur (one can also discover them by doing a Find for "WCAG 2.2" on the published page On first consideration, then, tactically it appears that a similar approach should be taken with 2.1 (keep all but 7 generic). Instead, what you have done in this update is left all 34 occurrences as WCAG 2.1 and modified the generic title to be 2.1 specific.. In other words, it has altered from something titled "How to refer to WCAG from Other Documents" to being specifically about "How to refer to WCAG 2.1 from Other Documents". This is a slight departure from the 2.1 specification itself, where the headings in some cases have been genericized to just "2" (but the specifics point to 2.1). So, the immediate question for me is: should the heading include "2", with or without the ".1"? This is a harder question to answer than one would expect, because although the existing 2.1 material includes 7 references to back to "2.0", each appears to be an error that should have been updated when the original 2.0 page was modified. In other words, it appears the authors intended this page to be exclusively about referencing 2.1, not either version of the spec. CONCLUSION: I think what you have done preserves the intent of 2.1 as published (and fixes some errors). That said, the 2.2 version is more generic. IMO, the same treatment employed in 2.2 could be used in 2.1 (i.e., modify to 2.1 references only the 7 occurrences highlighted in yellow in the first image I posted); however, I can also accept it as you have implemented it, so I am checking this off as resolved BUT I am cc'ing @bruce-usab on this for his review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every little thing is an improvement, so I think we should go forward with this. I would also characterize this PR as editor or bug fixes.
WCAG2-Issues TF will continue to iterate on substantive improvements to informative documents.
Not related to this PR specifically, but: the heading levels in https://www.w3.org/WAI/WCAG22/Understanding/non-text-contrast seem a bit haphazard later on - will file a separate issue. Also, while the technique in the 2.1 output https://kfranqueiro.github.io/wcag/techniques/failures/F78 doesn't list 2.4.13 which is WCAG 2.2 specific, the actual title of the technique includes it... For both of these, probably worth filing separate follow-up tweaks |
Again, not related to this PR, but noticed that https://www.w3.org/WAI/WCAG22/Understanding/text-spacing makes liberal use of |
I have held off on pushing updates to the styling for "SC", "Success Criterion/Criteria", etc., in the non-normative documents until we had a mechanism to correct across versions, which we will have after this. (The styling updates for normative content are included in the CFC.) |
Great catch @patrickhlauke! I'd argue that'd be a regression, so I've committed a fix. Here's what it impacts:
Both F55 and F78 referenced 2.4.13 in their title/h1 and that now gets removed. There was one other technique that referenced 3.3.8 and 3.3.9, but both of those are 2.2-only and so the entire technique is already suppressed in 2.1 output. |
Discussed on TF call 11/8. |
Background
There has long been interest in re-generating updated versions of the informative docs for WCAG 2.1. Previously, this relied upon a separate
WCAG-2.1
branch, but the ideal outcome is to be able to build directly frommain
, altering/pruning content as appropriate.Changes
This adds more functionality to the Eleventy-based build system to support building content targeting WCAG 2.1 in addition to 2.2, specifically when
WCAG_VERSION=21
is set in environment variables:target-size-enhanced
is output totarget-size
for 2.1refer-to-wcag
) via Liquid expressionsnote
andwcagXY
class on the same elementwcag22
classPreview
Do not use the Netlify preview for this, as it always builds 2.2 docs. (I've done a pass to verify that this PR doesn't visibly affect 2.2 output.)
I have set up a preview of this branch on my fork for the lifetime of this PR:
I have done quick-ish passes over both folders to try to spot and resolve any surprises. The Techniques pages largely only changed with respect to Test Rules (due to updated
act-mapping.json
) or the de-listing of obsolete techniques. I particularly looked over the Understanding pages since those align parallel with the guidelines and seem to have more meaningful updates. It is still possible that I have missed additional cases, e.g. of 2.2-specific wording that isn't properly enclosed in aclass="wcag22"
element. This ideally warrants a thorough review.The following Understanding pages inherit notable changes: (checkboxes included for review tracking purposes)