-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Reflow understanding doc #4055
base: main
Are you sure you want to change the base?
Conversation
This initial commit takes the current draft from the google doc that had been worked on for quite some time now, and makes it into a PR for further editing and review. Not all feedback from the google doc was directly taken/addressed, but there have been additional changes made that attempted to consider a good portion of the unresolved comments. Marking this PR as a draft, as there is still work to do (and I also need to upload all the new graphics for the examples - and a few examples still need to be created, which are currently marked as comments in the HTML file)
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fix some missing/stray markup end tags
Co-authored-by: Dan Bjorge <dan@dbjorge.net>
Briefly discussed on backlog call 9/6. |
attempt at further addressing issues: 2043 and 366
trying this text out to see what people think. again i'm wary about saying viewport here since that's not always what is needed.
attempting to briefly address issue 3311 and 648
making notes of existing issues addressed with this PR (more to come):
|
add in the carousel/swimlane examples that were noticed as missing during today's call. fix the broken animated gif and put it into a disclosure widget so that someone who doesn't want to see the animation can open/close it.
Discussed on backlog call 9/13, thank you @scottaohara! A preview is available but a reminder that the PR is still a work in progress. Most (but not all) content from Google Doc drafting has been pulled in and Scott has placeholders and inline notes-to-self. Looking really good! Outstanding question to @iadawn about replacing 4mb animated gif with an MP4, but where should a multimedia file go? TF would be okay with publishing without (and adding later) as the MVP need not be perfect. |
thanks @mfairchild365 for suggestions in simplifying my wordy intro paragraphs.
- wording updates per feedback i received off-github - added content to replace the "todo" placeholder content for section that introduces the carousel example
- spelling mistakes corrected - wording modifications to in brief section - expand tabular data section to call out grid-based UI, incorporating from off-github suggestion to reference "electronic program guides"
part 1 of at least 2. various wording adjustments for things that people commented could have been clearer. comment in the html to add a failing example (line 96)
the images were rather large - so made them a bit smaller to hopefully make the doc feel less 'broken up' by them
move the scoping of exceptions section into the exceptions section (preceded it, and that was weird) also fixes a paragraph with a missing start tag
Hearing the term for the first time. Is this a commonly used and understood thing? Explain? |
Masonry layout has been around for several years, initially using JavaScript to create the layout (for example: Cascading grid layout library). It's slowly being standardized (for example: Masonry layout). |
Discussed on backlog call 2/7. @gundulaniemann offered to make one more editorial pass. TF goal is to send to AG by next Friday (2/17). |
added in mention of visual grid / masonry layouts to the end of the 'single column' section. fixed a few typos / tried to shorten some content.
some rewording since i was trying to stress that increasing zoom makes the viewport smaller. but i reworked the text a bit to make that clearer / work with all the other suggestions from #4055 (comment)
thank you @fstrr for doing the majority of the setup for this example.
add new example revise text per feedback
I had another look at the preview to see everything in context. Is it possible to add an image of an "electronic program guide"? I have no idea how this might look like, even not from the description. My next finding has three points, ending with a question.
I see the test rule "Meta viewport allows for zoom" says all examples passing it also pass reflow, yet the original is for resizing text, which does not imply two dimensional scrolling to be avoided. |
@patrickhlauke to make a stylised/simplified diagram for what an EPG looks like (a la https://en.wikipedia.org/wiki/File:Mythbuntu_Program_Guide.png) |
i'm commenting this out for now. as mentioned, not every understanding doc has a benefits section. This benefits section made sense in the old version of this understanding doc - but with the new in brief content, and the heavily revised content of this doc, this benefits section is redundant to other content now in this doc, and otherwise lacking in detail.
some quick notes to about the responses to gundula's prior comment in this issue, which were made during the task force call today (but posting here so others who may read this issue don't think the comment went unaddressed):
|
Wow, perfect timing! I just committed the update with the second example for comparison. Feel free to tweak the explanation if it's not clear enough! Thanks @scottaohara for all of this! Truly amazing work! |
This is the link to the preview: https://deploy-preview-4055--wcag2.netlify.app/working-examples/reflow-nested-lists/ |
thank you @giacomo-petri. i played around with some of the wording and expanded the last paragraph that introduces the examples a bit. really appreciate you getting this done so quickly. |
This initial commit takes the current draft from the google doc that had been worked on for quite some time now, and makes it into a PR for further editing and review.
Not all feedback from the google doc was directly taken/addressed, but there have been additional changes made that attempted to consider a good portion of the unresolved comments.
Marking this PR as a draft, as there is still work to do (and I also need to upload all the new graphics for the examples - and a few examples still need to be created, which are currently marked as comments in the HTML file).
The latest updates will be visible via this preview link of the understanding doc
Closes #3121)