Skip to content

Conversation

@adampage
Copy link
Member

While developing #4829, I discovered that my h1 text for the new page wasn’t successfully retrieved by the build system because I’d hard-wrapped the lines like so:

<h1>
  Failure of Success Criterion 1.3.1 due to visible ruby annotations that
  are not programmatically determinable
</h1>

@kfranqueiro, would it be alright to tweak the build system to permit wrapped heading text like this?

@adampage adampage self-assigned this Dec 27, 2025
@netlify
Copy link

netlify bot commented Dec 27, 2025

Deploy Preview for wcag2 ready!

Name Link
🔨 Latest commit 4da67cc
🔍 Latest deploy log https://app.netlify.com/projects/wcag2/deploys/694f84dbbe18c400084803ed
😎 Deploy Preview https://deploy-preview-4831--wcag2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@adampage adampage added the Tooling Anything github / build process related label Dec 27, 2025
@kfranqueiro
Copy link
Contributor

kfranqueiro commented Jan 2, 2026

The build system already supports wrapping whitespace in the level-1 heading of techniques. However, as you point out, it is not handling leading/trailing whitespace correctly.

If you look a few lines later than where you adjusted, title and titleHtml both contain the full title; only truncatedTitle gets the middle truncated, which is typically used for link text. Believe it or not, this was based on existing (probably accidental) behavior from the older XSLT build system, with the added adjustment of inserting an ellipsis where content was removed from the middle.

This PR, as written, ends up undoing the functionality that I pointed out lower in the file. I have created #4846 to fix this without regressions.

@adampage
Copy link
Member Author

adampage commented Jan 2, 2026

Got it — thanks for the explanation and follow-up PR, @kfranqueiro. 🙏🏻

kfranqueiro added a commit that referenced this pull request Jan 5, 2026
This fixes the issue reported in #4831 while avoiding regressions to
existing link text truncation logic.

(This does cause some whitespace changes in output, but they are not
noticeable in the rendered HTML.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Fixes Tooling Anything github / build process related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants