Fixes to WCAG 2.1 Understanding 2.4.6 and 3.3.2 #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly mention that 2.4.6 is NOT concerned with correct markup/identification of headings/labels.
The "People who have difficulty using their hands" benefit here is not explained, and appears to be more of a benefit assuming that headings are correctly marked up per 1.3.1, and that the users are either navigating an automated TOC that links to headings, or are using additional AT that allows for heading-based navigation. All of this is not related to whether or not headings are actually descriptive. The "This Success Criterion helps people who use screen readers" benefit again hinges more on 1.3.1 first and foremost. As it's not a requirement of THIS particular SC that headings be correctly marked up, it's not really a benefit per se of this SC directly. May reintroduce this in reworded form. The "This Success Criterion may also help users with low vision who can see only a few words at a time" benefit seems to be a complete non-sequitur, as descriptive headings/labels may vary in length and won't necessarily benefit this user group in the way described.
…that it hinges on 1.3.1 additional small correction, for consistency, capitalizing "Success Criterion"
Explicitly mention that 3.3.2 is NOT concerned with correct markup/identification/association of labels/instructions.
The "When label elements are associated with input elements the label is spoken by screen readers..." benefit hinges purely on 1.3.1, not 3.3.2 The "Field labels located in close proximity to the associated field assist users of screen magnifiers..." hinges on the concept of 'proximity', which has nothing to do with this SC, and is not normatively defined anywhere in WCAG?
Made the two remaining benefits more generalized, while providing clearer context.
…efits additionally, split an overly long line in markup to two lines
patrickhlauke
changed the title
As auditors (at least in my experience) are often confused by the different, yet complementary, aspects of what is asserted by 2.4.6 and 3.3.2
As auditors (at least in my experience) are often confused by the different, yet complementary, aspects of what is asserted by 2.4.6 and 3.3.2
michael-n-cooper
approved these changes
Feb 10, 2019
There was a problem hiding this comment.
Structurally this is fine, edits are in the correct place. We might want to decide if it makes sense to continue maintaining Understanding files in a version folder, but it made sense at the time and is what is currently supported.
I question having several paragraphs in a note, as I think notes should be brief and if content is longer it's no longer a note, it should be worked into the main text. I also question whether what appears to be nearly identical content should be in multiple Understanding files, as it's repetitive and reduces the distinction between the relevant SC. But I'll leave those issues for the WG process, this review is just on structural aspects.
awkawk
reviewed
Feb 10, 2019
awkawk
reviewed
Feb 11, 2019
awkawk
reviewed
Feb 11, 2019
awkawk
reviewed
Feb 11, 2019
|
@patrickhlauke The WG approves the direction, although @mbgower will have some input on the pull request. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #610
(note I wasn't sure whether to make the fixes on these files, which are in the 2.0 folder, or whether or not I should have created new instances of these in the 2.1 folder)