Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Motion actuation failure #845
Motion actuation failure #845
Changes from 14 commits
c68240b
6cbba44
a7b6821
c23c716
76cdc1b
6026b1c
5cd576c
4a9b2f3
c69c5d2
5996b71
5fef56c
c42ac24
1d6027f
b9c7b23
c16bb96
3d6a0db
cd8f9f2
39d1d1f
f8c99f8
d537d3d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@awkawk I updated the procedure to account for the exceptions in the SC text, if it impacts what you were going to look at for the other failures?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patrickhlauke I'm not entirely sure I understand what an accessibility interface for this would be, does the procedure for motion actuation make sense? (Mainly item 2)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some OSs offer some accessibility options that can fake motion (mapped to a button or similar instead), i believe. might be that sort of thing this is referring/alluding to?