Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use [=AbortSignal/abort reason=] #86

Merged
merged 7 commits into from
Dec 14, 2021
Merged

Use [=AbortSignal/abort reason=] #86

merged 7 commits into from
Dec 14, 2021

Conversation

saschanaz
Copy link
Member

@saschanaz saschanaz commented Nov 10, 2021 •
edited by pr-preview bot
Loading

From whatwg/dom#1030

cc @annevk

Will also modify relevant WPT tests soon.

Preview | Diff

saschanaz
saschanaz commented Nov 10, 2021
View reviewed changes
index.bs Show resolved Hide resolved
inexorabletash
inexorabletash approved these changes Nov 10, 2021
View reviewed changes
index.bs Show resolved Hide resolved
annevk
annevk reviewed Nov 10, 2021
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @saschanaz! Looks (mostly) great.

index.bs Outdated Show resolved Hide resolved
index.bs Show resolved Hide resolved
@annevk annevk mentioned this pull request Nov 10, 2021
Closed
13 tasks
@inexorabletash
Copy link
Member

I think we can merge once WPTs are ready... and how are implementations going?

@saschanaz
Copy link
Member Author

Will take a look at Gecko implementation soon-ish.

@inexorabletash inexorabletash mentioned this pull request Nov 12, 2021
Merged
inexorabletash added a commit that referenced this pull request Nov 12, 2021
@inexorabletash
Editorial: Turn on 'Assume Explicit For' (#92)
c5e09d1 
Factor turning on "Assume Explicit For" out of #75.

Purely editorial, adding "blah/" as needed to satisfy Bikeshed.

Note that "No 'dfn' refs found for 'aborted flag' with for='['AbortSignal']'." is currently reported, will be fixed by #86
saschanaz added a commit to saschanaz/web-locks that referenced this pull request Nov 12, 2021
@saschanaz
Use [=AbortSignal/aborted=]
db9fea5 
Split from w3c#86 as it's not directly related to abort reasons.
@saschanaz saschanaz mentioned this pull request Nov 12, 2021
Merged
inexorabletash pushed a commit that referenced this pull request Nov 12, 2021
@saschanaz
Use [=AbortSignal/aborted=] (#93)
e017adc 
Split from #86 as it's not directly related to abort reasons.
@saschanaz
Copy link
Member Author

The patch has landed to Gecko and WPT changes are here: web-platform-tests/wpt#32055

@inexorabletash
Copy link
Member

Nice! I suppose we need a tracking bug in Blink...

@saschanaz
Copy link
Member Author

Could you open one or should I?

@inexorabletash inexorabletash merged commit 526a0fe into w3c:main Dec 14, 2021
@saschanaz saschanaz deleted the abort-reason branch December 14, 2021 17:32
github-actions bot added a commit that referenced this pull request Dec 14, 2021
@saschanaz @github-actions
Use [=AbortSignal/abort reason=] (#86)
3a40831 
SHA: 526a0fe
Reason: push, by @inexorabletash

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@inexorabletash
Copy link
Member

crbug.com/1279877

@inexorabletash inexorabletash mentioned this pull request Aug 9, 2022
Closed
@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Dec 15, 2022
Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Dec 15, 2022
@inexorabletash @chromium-wpt-export-bot
Web Locks: If aborted due to an AbortSignal, use signal's reason
037fff2 
Updated in the spec a year ago[1], if the AbortSignal has a reason,
use that as the rejection, rather than a stock AbortError w/ hardcoded
message.

The WPTs didn't cover verifying the reason for an already-aborted
signal, so add coverage for those cases too.

[1] w3c/web-locks#86

Bug: 1279877
Change-Id: I9838805b10dbb3dae0371abe41faf922344a43f3
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Dec 16, 2022
@inexorabletash @chromium-wpt-export-bot
Web Locks: If aborted due to an AbortSignal, use signal's reason
8a07323 
Updated in the spec a year ago[1], if the AbortSignal has a reason,
use that as the rejection, rather than a stock AbortError w/ hardcoded
message.

The WPTs didn't cover verifying the reason for an already-aborted
signal, so add coverage for those cases too.

[1] w3c/web-locks#86

Bug: 1279877
Change-Id: I9838805b10dbb3dae0371abe41faf922344a43f3
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Dec 16, 2022
@inexorabletash @chromium-wpt-export-bot
Web Locks: If aborted due to an AbortSignal, use signal's reason
4081fa8 
Updated in the spec a year ago[1], if the AbortSignal has a reason,
use that as the rejection, rather than a stock AbortError w/ hardcoded
message.

The WPTs didn't cover verifying the reason for an already-aborted
signal, so add coverage for those cases too.

[1] w3c/web-locks#86

Bug: 1279877
Change-Id: I9838805b10dbb3dae0371abe41faf922344a43f3
aarongable pushed a commit to chromium/chromium that referenced this pull request Dec 16, 2022
@inexorabletash
Web Locks: If aborted due to an AbortSignal, use signal's reason
473043a 
Updated in the spec a year ago[1], if the AbortSignal has a reason,
use that as the rejection, rather than a stock AbortError w/ hardcoded
message.

The WPTs didn't cover verifying the reason for an already-aborted
signal, so add coverage for those cases too.

[1] w3c/web-locks#86

Bug: 1279877
Change-Id: I9838805b10dbb3dae0371abe41faf922344a43f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4112925
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1084556}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Dec 16, 2022
@inexorabletash @chromium-wpt-export-bot
Web Locks: If aborted due to an AbortSignal, use signal's reason
de1f863 
Updated in the spec a year ago[1], if the AbortSignal has a reason,
use that as the rejection, rather than a stock AbortError w/ hardcoded
message.

The WPTs didn't cover verifying the reason for an already-aborted
signal, so add coverage for those cases too.

[1] w3c/web-locks#86

Bug: 1279877
Change-Id: I9838805b10dbb3dae0371abe41faf922344a43f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4112925
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1084556}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Dec 16, 2022
@inexorabletash @chromium-wpt-export-bot
Web Locks: If aborted due to an AbortSignal, use signal's reason
9ce4a64 
Updated in the spec a year ago[1], if the AbortSignal has a reason,
use that as the rejection, rather than a stock AbortError w/ hardcoded
message.

The WPTs didn't cover verifying the reason for an already-aborted
signal, so add coverage for those cases too.

[1] w3c/web-locks#86

Bug: 1279877
Change-Id: I9838805b10dbb3dae0371abe41faf922344a43f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4112925
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1084556}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Dec 22, 2022
@inexorabletash @moz-wptsync-bot
Bug 1806016 [wpt PR 37535] - Web Locks: If aborted due to an AbortSig…
133ebea 
…nal, use signal's reason, a=testonly

Automatic update from web-platform-tests
Web Locks: If aborted due to an AbortSignal, use signal's reason

Updated in the spec a year ago[1], if the AbortSignal has a reason,
use that as the rejection, rather than a stock AbortError w/ hardcoded
message.

The WPTs didn't cover verifying the reason for an already-aborted
signal, so add coverage for those cases too.

[1] w3c/web-locks#86

Bug: 1279877
Change-Id: I9838805b10dbb3dae0371abe41faf922344a43f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4112925
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1084556}

--

wpt-commits: 9ce4a6482a088da3d74f895d8ad15c5ce0c25d28
wpt-pr: 37535
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Jan 3, 2023
@inexorabletash @moz-wptsync-bot
Bug 1806016 [wpt PR 37535] - Web Locks: If aborted due to an AbortSig…
91934b8 
…nal, use signal's reason, a=testonly

Automatic update from web-platform-tests
Web Locks: If aborted due to an AbortSignal, use signal's reason

Updated in the spec a year ago[1], if the AbortSignal has a reason,
use that as the rejection, rather than a stock AbortError w/ hardcoded
message.

The WPTs didn't cover verifying the reason for an already-aborted
signal, so add coverage for those cases too.

[1] w3c/web-locks#86

Bug: 1279877
Change-Id: I9838805b10dbb3dae0371abe41faf922344a43f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4112925
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1084556}

--

wpt-commits: 9ce4a6482a088da3d74f895d8ad15c5ce0c25d28
wpt-pr: 37535
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk left review comments

@inexorabletash inexorabletash inexorabletash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saschanaz @inexorabletash @annevk