Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define RP processing of be and bs flags during .create() and .get() #1907

Merged
merged 6 commits into from
Aug 9, 2023

Conversation

MasterKale
Copy link
Contributor

@MasterKale MasterKale commented Jun 14, 2023

The spec was light on details on how to handle a couple of states of the be and bs flags coming out of calls to .create() and .get(). This PR tries to clarify RP handling of potential combinations of these flags during registration and authentication:

  1. A device-bound credential indicates that it is backed up during registration (be:0+bs:1)
  2. A device-bound credential indicates that it is backed up after authentication (be:0+bs:1)
  3. A credential's backup eligibility changes after registration (be:0 -> be:1 or be:1 -> be:0)

This should address #1791.


Preview | Diff

Copy link
Contributor

@Firstyear Firstyear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addresses my concerns yes :)

index.bs Outdated Show resolved Hide resolved
index.bs Show resolved Hide resolved
@emlun emlun self-requested a review June 28, 2023 19:16
index.bs Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
@MasterKale
Copy link
Contributor Author

Confirmed during the meeting that since no objections came up on 7/21 it's okay to merge this outside of a WAWG meeting, once @emlun approves.

Copy link
Member

@emlun emlun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@MasterKale MasterKale merged commit 6b68667 into main Aug 9, 2023
1 check passed
@MasterKale MasterKale deleted the 1791-enforce-be-bs-flag-states branch August 9, 2023 19:45
github-actions bot added a commit that referenced this pull request Aug 9, 2023
SHA: 6b68667
Reason: push, by MasterKale

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants