Allow use of credProps extension during auth #1988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emlun
reviewed
Oct 13, 2023
agl
approved these changes
Nov 1, 2023
timcappalli
approved these changes
Nov 1, 2023
emlun
requested changes
Nov 10, 2023
Add credProps client processing step to set authenticatorDisplayName
|
@emlun This is ready for your review again. There doesn't seem to be anything actionable anymore for me atm so maybe we can merge this today... |
pascoej
approved these changes
Nov 15, 2023
akshayku
approved these changes
Nov 15, 2023
emlun
approved these changes
Nov 16, 2023
github-actions bot
added a commit
that referenced
this pull request
Nov 29, 2023
SHA: 84feb40 Reason: push, by nicksteele Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to selfissued/webauthn
that referenced
this pull request
Nov 29, 2023
SHA: 84feb40 Reason: push, by selfissued Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to VoltrexKeyva/webauthn
that referenced
this pull request
Dec 3, 2023
SHA: 84feb40 Reason: push, by VoltrexKeyva Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
credPropsextension to be something that can be used during authentication as well.During discussion of #1880 the idea came up that if credProps were available during auth too then, in the future when passkeys can be moved between providers, RP's might benefit from receiving a new credential nickname after the user migrates providers but a new entry in
supplementalPubKeys(#1957) indicates to the RP that the credential's provider changed.Preview | Diff