Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update obsolete privacy concerns about throwing errors early #2134

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

emlun
Copy link
Member

@emlun emlun commented Sep 4, 2024

Given the conclusions in #2132 (comment) and #2132 (comment), update the respective privacy concerns and remove the obsolete restrictions against returning "NotAllowedError" before the timeout expires. This simplifies some aspects of #2095 and #2096 (see: #2095 (comment)).

Closes #2132.

The following tasks have been completed:

  • [ ] Modified Web platform tests (No applicable tests)

Implementation commitment:

  • (This change only removes restrictions, but does not require action from implementers.)

Documentation and checks


Preview | Diff

Copy link
Contributor

@MasterKale MasterKale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for wading into this and modernizing these privacy concerns. This'll definitely simplify discussions around adding new errors to WebAuthn.

@nadalin nadalin added this to the L3-WD-02 milestone Sep 12, 2024
@nadalin nadalin added the @Risk Items that are at risk for L3 label Sep 12, 2024
Copy link
Member

@timcappalli timcappalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@Risk Items that are at risk for L3 subtype:impl-cons type:technical
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review privacy concerns around error conditions
5 participants