-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add table numbers and captions #994
Conversation
I recommend activating "hide whitespace changes" in the diff settings while reviewing this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx @emlun! (yet again ;) -- only thing I'd add is that we now have another table in https://w3c.github.io/webauthn/#sctn-authenticator-taxonomy to add a caption to. I merged from master into this branch so that table is here now.
oh, and we do need the new <style> -- i.e., it works except for auto-incrementing the table number? I'm guessing "yes" is the answer.
Ok, I'll do this for the new table too. Thanks! Yes, the style is needed. Here is how Bikeshed's builtin figure numbering works; without the styles added here, these tables would be captioned and numbered as figures. Oh, but maybe |
Nope, The |
See also speced/bikeshed#1314 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx @emlun !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me
Fixes #990.
Preview | Diff