-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signed versus unsigned #284
Comments
In various container formats, negative frame timestamps can sometimes be useful to indicate stream cropping or decoder preroll. For example, in WebM: https://bugs.chromium.org/p/chromium/issues/detail?id=271794#c14. |
Queue sizes can't be negative. They were originally modelled after the Streams API which can have negative queue space available, but differ enough now that there is no reason for them to be signed still. |
signed timestamps were resolved here #122 (comment) |
@sandersdan Thanks! Would it make sense to provide a PR to make the queue sizes unsigned? |
Editors call: WebAudio and WebRTC seem to use unsigned for these types of counts. SGTM |
is
timestamp
really intended to be a signed long long? Typically, timestamps are unsigned.Had the same question about
decodeQueueSize
andencodeQueueSize
. Those can't be negative, right?The text was updated successfully, but these errors were encountered: