Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImageDecoder is [SecureContext] but related interfaces aren't #798

Open
padenot opened this issue Jun 7, 2024 · 2 comments · May be fixed by #801
Open

ImageDecoder is [SecureContext] but related interfaces aren't #798

padenot opened this issue Jun 7, 2024 · 2 comments · May be fixed by #801

Comments

@padenot
Copy link
Collaborator

padenot commented Jun 7, 2024

We noticed this while implementing, it's a bit unusual, ImageTrack and ImageTrackList are exposed on non-secure context. Reading the old PR, I didn't manage to find a particular reason, maybe it's just an oversight?
@alvestrand
Copy link

Fingerprint surface?

@dalecurtis
Copy link
Contributor

Just an oversight. I'll mark them as SecureContext in Chrome and hope that doesn't break anything.

aarongable pushed a commit to chromium/chromium that referenced this issue Jun 7, 2024
@dalecurtis
Mark ImageTrack, ImageTrackList as SecureContext.
4af99b1 
These are only constructible by ImageDecoder which is SecureContext,
so they should be SecureContext as well.

Bug: w3c/webcodecs#798

Change-Id: Ic7591ca038121b0674d2903ccd1048a641a7839e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5606098
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1312273}
@dalecurtis dalecurtis linked a pull request Jun 10, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add SecureContext to ImageTrack, ImageTrackList w3c/webcodecs
3 participants
@padenot @alvestrand @dalecurtis