Make VideoFrame/AudioData Transferable and Serializable #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also some cleanups of clone/close algos.
chrisn
reviewed
Jun 22, 2021
chcunningham
changed the title
And other minor fixes.
chcunningham
commented
Jul 6, 2021
|
Reviewers, pls let me know if this looks good. |
padenot
approved these changes
Jul 13, 2021
|
@aboba I think this one's probably not controversial, so proceeding w/ merge. Happy to iterate if you see any issues. |
github-actions bot
added a commit
that referenced
this pull request
Jul 14, 2021
SHA: 09f2655 Reason: push, by @chcunningham Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Jul 14, 2021
SHA: 09f2655 Reason: push, by @chcunningham Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Jul 14, 2021
SHA: 09f2655 Reason: push, by @chcunningham Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transfer "moves", serialize "clones".
Fixes #210.
Preview | Diff