Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Web IDL's new-ish interface mixins concept #194

Merged
merged 1 commit into from
May 10, 2018
Merged

Conversation

romandev
Copy link
Member

WebIDL recently introduced dedicated syntax for mixins [1]. This
replaces the existing [NoInterfaceObject] and "implements" syntax with
"interface mixin" and "includes" in the appropriate places.

This fixes #191 issue.

Test: web-platform-tests/wpt#8767

WebIDL recently introduced dedicated syntax for mixins [1]. This
replaces the existing [NoInterfaceObject] and "implements" syntax with
"interface mixin" and "includes" in the appropriate places.

This fixes w3c#191 issue.

Test: web-platform-tests/wpt#8767
@marcoscaceres
Copy link
Member

Friendly ping.

@saschanaz
Copy link
Member

saschanaz commented Apr 15, 2018

This is okay, but how about using partial interface mixin as the Web IDL spec suggests?

For example, instead of the common but verbose:

interface mixin GlobalCrypto {
 readonly attribute Crypto crypto;
};

Window includes GlobalCrypto;
WorkerGlobalScope includes GlobalCrypto;

you can extend the WindowOrWorkerGlobalScope interface mixin using a partial interface mixin:

partial interface mixin WindowOrWorkerGlobalScope {
 readonly attribute Crypto crypto;
};

@marcoscaceres
Copy link
Member

@plehegar, would be a great help if you can get this merged. It's blocking removal of implements in various places.

@plehegar plehegar merged commit 50fee42 into w3c:master May 10, 2018
@plehegar
Copy link
Member

Merged. The case to use mixin can still be made separately. I just didn't want to hold the correction in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update WebIDL definition(s) to use new mixin syntax
4 participants