Skip to content

Commit

Permalink
Fix use of for-in on ECMAScript Iterator
Browse files Browse the repository at this point in the history 
SHA: dbca1e3
Reason: push, by jgraham

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
  • Loading branch information
@lolaodelola @github-actions
lolaodelola and github-actions[bot] committed Jul 27, 2023
1 parent 5a2c98d commit 9cf6443
Showing 1 changed file with 9 additions and 7 deletions.
16 changes: 9 additions & 7 deletions index.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<link href="https://www.w3.org/StyleSheets/TR/2021/W3C-ED" rel="stylesheet">
<meta content="Bikeshed version d29f71adb, updated Wed Jul 19 11:08:56 2023 -0700" name="generator">
<link href="https://w3c.github.io/webdriver-bidi/" rel="canonical">
<meta content="2d97074fcbff3d023a56fbda6525346e6822c7c2" name="document-revision">
<meta content="dbca1e359ed04d8bf7fda33d7e0c04d61ff72451" name="document-revision">
<style>
var {
color: #cd5c5c
Expand Down Expand Up @@ -544,7 +544,7 @@
<div class="head">
<p data-fill-with="logo"><a class="logo" href="https://www.w3.org/"> <img alt="W3C" height="48" src="https://www.w3.org/StyleSheets/TR/2021/logos/W3C" width="72"> </a> </p>
<h1 class="p-name no-ref" id="title">WebDriver BiDi</h1>
<p id="w3c-state"><a href="https://www.w3.org/standards/types#ED">Editor’s Draft</a>, <time class="dt-updated" datetime="2023-07-26">26 July 2023</time></p>
<p id="w3c-state"><a href="https://www.w3.org/standards/types#ED">Editor’s Draft</a>, <time class="dt-updated" datetime="2023-07-27">27 July 2023</time></p>
<details open>
<summary>More details about this document</summary>
<div data-fill-with="spec-metadata">
Expand Down Expand Up @@ -5701,7 +5701,7 @@ <h5 class="heading settled" data-level="6.5.3.13" id="type-script-RemoteValue"><
<li data-md>
<p>Let <var>serialized</var> be a new list.</p>
<li data-md>
<p>For each <var>child value</var> in <var>iterable</var>:</p>
<p>For each <var>child value</var> in <a data-link-type="dfn" href="https://tc39.es/ecma262/#sec-iteratortolist" id="ref-for-sec-iteratortolist">IteratorToList</a>(<a data-link-type="dfn" href="https://tc39.es/ecma262/#sec-getiterator" id="ref-for-sec-getiterator">GetIterator</a>(<var>iterable</var>, sync)):</p>
<ol>
<li data-md>
<p>Let <var>child serialization options</var> be a <a data-link-type="dfn" href="https://infra.spec.whatwg.org/#map-clone" id="ref-for-map-clone①">clone</a> of <var>serialization options</var>.</p>
Expand All @@ -5719,9 +5719,8 @@ <h5 class="heading settled" data-level="6.5.3.13" id="type-script-RemoteValue"><
<p>Return <var>serialized</var></p>
</ol>
</div>
<p class="issue" id="issue-c12b3c7f"><a class="self-link" href="#issue-c12b3c7f"></a> this assumes for-in works on iterators</p>
<div class="algorithm" data-algorithm="serialize as a mapping">
To <dfn class="dfn-paneled" data-dfn-type="dfn" data-noexport id="serialize-as-a-mapping">serialize as a mapping</dfn> given <var>iterable</var>, <var>serialization options</var>, <var>ownership type</var>, <var>serialization internal map</var>, <var>realm</var>, and <var>session</var>:
<p>To <dfn class="dfn-paneled" data-dfn-type="dfn" data-noexport id="serialize-as-a-mapping">serialize as a mapping</dfn> given <var>iterable</var>, <var>serialization options</var>, <var>ownership type</var>, <var>serialization internal map</var>, <var>realm</var>, and <var>session</var>:</p>
<ol>
<li data-md>
<p>If <var>serialization options</var>["<code>maxObjectDepth</code>"] is not null,
Expand All @@ -5730,7 +5729,7 @@ <h5 class="heading settled" data-level="6.5.3.13" id="type-script-RemoteValue"><
<li data-md>
<p>Let <var>serialized</var> be a new list.</p>
<li data-md>
<p>For <var>item</var> in <var>iterable</var>:</p>
<p>For <var>item</var> in <a data-link-type="dfn" href="https://tc39.es/ecma262/#sec-iteratortolist" id="ref-for-sec-iteratortolist①">IteratorToList</a>(<a data-link-type="dfn" href="https://tc39.es/ecma262/#sec-getiterator" id="ref-for-sec-getiterator①">GetIterator</a>(<var>iterable</var>, sync)):</p>
<ol>
<li data-md>
<p class="assertion">Assert: <a data-link-type="dfn" href="https://tc39.es/ecma262/#sec-isarray" id="ref-for-sec-isarray①">IsArray</a>(<var>item</var>)</p>
Expand Down Expand Up @@ -7421,11 +7420,13 @@ <h3 class="no-num no-ref heading settled" id="index-defined-elsewhere"><span cla
<li><span class="dfn-paneled" id="1ba60810">date.toisostring</span>
<li><span class="dfn-paneled" id="7ef0edbd">enumerableownpropertynames</span>
<li><span class="dfn-paneled" id="47eb8c57">get</span>
<li><span class="dfn-paneled" id="99403468">getiterator</span>
<li><span class="dfn-paneled" id="900ce14b">internal slot</span>
<li><span class="dfn-paneled" id="8f3fa597">isarray</span>
<li><span class="dfn-paneled" id="1754fd49">iscallable</span>
<li><span class="dfn-paneled" id="7728ef75">ispromise</span>
<li><span class="dfn-paneled" id="a60df0fb">isregexp</span>
<li><span class="dfn-paneled" id="b7d560f9">iteratortolist</span>
<li><span class="dfn-paneled" id="e0160a7c">map</span>
<li><span class="dfn-paneled" id="f74eadef">null</span>
<li><span class="dfn-paneled" id="832894ed">object.fromentries</span>
Expand Down Expand Up @@ -7861,7 +7862,6 @@ <h2 class="no-num no-ref heading settled" id="issues-index"><span class="content
<div class="issue"> reconsider mirror objects' lifecycle. <a class="issue-return" href="#issue-c8a585bd" title="Jump to section">↵</a></div>
<div class="issue"> <var>children</var> and child nodes are different things. Either <code>childNodeCount</code> should
reference to <code>childNodes</code>, or it should be renamed to <code>childrenCount</code>. <a class="issue-return" href="#issue-4a5a93fc" title="Jump to section">↵</a></div>
<div class="issue"> this assumes for-in works on iterators <a class="issue-return" href="#issue-c12b3c7f" title="Jump to section">↵</a></div>
<div class="issue"> This has the wrong error code <a class="issue-return" href="#issue-89e6b783①" title="Jump to section">↵</a></div>
<div class="issue"> TODO: Add timeout argument as described in the script.evaluate. <a class="issue-return" href="#issue-6eade172" title="Jump to section">↵</a></div>
<div class="issue"> Extend this to also allow realm parents e.g. for nested workers? Or get all ancestor workers. <a class="issue-return" href="#issue-ac9113ee" title="Jump to section">↵</a></div>
Expand Down Expand Up @@ -8234,11 +8234,13 @@ <h2 class="no-num no-ref heading settled" id="issues-index"><span class="content
window.dfnpanelData['1ba60810'] = {"dfnID": "1ba60810", "url": "https://tc39.es/ecma262/#sec-date.prototype.toisostring", "dfnText": "date.toisostring", "refSections": [{"refs": [{"id": "ref-for-sec-date.prototype.toisostring"}], "title": "6.5.3.13. The script.RemoteValue Type"}], "external": true};
window.dfnpanelData['7ef0edbd'] = {"dfnID": "7ef0edbd", "url": "https://tc39.es/ecma262/#sec-enumerableownpropertynames", "dfnText": "enumerableownpropertynames", "refSections": [{"refs": [{"id": "ref-for-sec-enumerableownpropertynames"}], "title": "6.5.3.13. The script.RemoteValue Type"}], "external": true};
window.dfnpanelData['47eb8c57'] = {"dfnID": "47eb8c57", "url": "https://tc39.es/ecma262/#sec-get", "dfnText": "get", "refSections": [{"refs": [{"id": "ref-for-sec-get"}, {"id": "ref-for-sec-get\u2460"}, {"id": "ref-for-sec-get\u2461"}, {"id": "ref-for-sec-get\u2462"}, {"id": "ref-for-sec-get\u2463"}, {"id": "ref-for-sec-get\u2464"}], "title": "6.5.3.13. The script.RemoteValue Type"}], "external": true};
window.dfnpanelData['99403468'] = {"dfnID": "99403468", "url": "https://tc39.es/ecma262/#sec-getiterator", "dfnText": "getiterator", "refSections": [{"refs": [{"id": "ref-for-sec-getiterator"}, {"id": "ref-for-sec-getiterator\u2460"}], "title": "6.5.3.13. The script.RemoteValue Type"}], "external": true};
window.dfnpanelData['900ce14b'] = {"dfnID": "900ce14b", "url": "https://tc39.es/ecma262/#sec-object-internal-methods-and-internal-slots", "dfnText": "internal slot", "refSections": [{"refs": [{"id": "ref-for-sec-object-internal-methods-and-internal-slots"}, {"id": "ref-for-sec-object-internal-methods-and-internal-slots\u2460"}, {"id": "ref-for-sec-object-internal-methods-and-internal-slots\u2461"}, {"id": "ref-for-sec-object-internal-methods-and-internal-slots\u2462"}, {"id": "ref-for-sec-object-internal-methods-and-internal-slots\u2463"}, {"id": "ref-for-sec-object-internal-methods-and-internal-slots\u2464"}, {"id": "ref-for-sec-object-internal-methods-and-internal-slots\u2465"}, {"id": "ref-for-sec-object-internal-methods-and-internal-slots\u2466"}, {"id": "ref-for-sec-object-internal-methods-and-internal-slots\u2467"}], "title": "6.5.3.13. The script.RemoteValue Type"}], "external": true};
window.dfnpanelData['8f3fa597'] = {"dfnID": "8f3fa597", "url": "https://tc39.es/ecma262/#sec-isarray", "dfnText": "isarray", "refSections": [{"refs": [{"id": "ref-for-sec-isarray"}, {"id": "ref-for-sec-isarray\u2460"}], "title": "6.5.3.13. The script.RemoteValue Type"}], "external": true};
window.dfnpanelData['1754fd49'] = {"dfnID": "1754fd49", "url": "https://tc39.es/ecma262/#sec-iscallable", "dfnText": "iscallable", "refSections": [{"refs": [{"id": "ref-for-sec-iscallable"}], "title": "6.5.2. Preload Scripts"}, {"refs": [{"id": "ref-for-sec-iscallable\u2460"}], "title": "6.5.3.13. The script.RemoteValue Type"}, {"refs": [{"id": "ref-for-sec-iscallable\u2461"}], "title": "6.5.4.3. The script.callFunction Command"}], "external": true};
window.dfnpanelData['7728ef75'] = {"dfnID": "7728ef75", "url": "https://tc39.es/ecma262/#sec-ispromise", "dfnText": "ispromise", "refSections": [{"refs": [{"id": "ref-for-sec-ispromise"}], "title": "6.5.3.13. The script.RemoteValue Type"}, {"refs": [{"id": "ref-for-sec-ispromise\u2460"}], "title": "6.5.4.3. The script.callFunction Command"}, {"refs": [{"id": "ref-for-sec-ispromise\u2461"}], "title": "6.5.4.4. The script.evaluate Command"}], "external": true};
window.dfnpanelData['a60df0fb'] = {"dfnID": "a60df0fb", "url": "https://tc39.es/ecma262/#sec-isregexp", "dfnText": "isregexp", "refSections": [{"refs": [{"id": "ref-for-sec-isregexp"}], "title": "6.5.3.13. The script.RemoteValue Type"}], "external": true};
window.dfnpanelData['b7d560f9'] = {"dfnID": "b7d560f9", "url": "https://tc39.es/ecma262/#sec-iteratortolist", "dfnText": "iteratortolist", "refSections": [{"refs": [{"id": "ref-for-sec-iteratortolist"}, {"id": "ref-for-sec-iteratortolist\u2460"}], "title": "6.5.3.13. The script.RemoteValue Type"}], "external": true};
window.dfnpanelData['e0160a7c'] = {"dfnID": "e0160a7c", "url": "https://tc39.es/ecma262/#sec-map-iterable", "dfnText": "map", "refSections": [{"refs": [{"id": "ref-for-sec-map-iterable"}], "title": "6.5.3.6. The script.LocalValue Type"}], "external": true};
window.dfnpanelData['f74eadef'] = {"dfnID": "f74eadef", "url": "https://tc39.es/ecma262/#sec-null-value", "dfnText": "null", "refSections": [{"refs": [{"id": "ref-for-sec-null-value"}], "title": "6.5.3.9. The script.PrimitiveProtocolValue Type"}], "external": true};
window.dfnpanelData['832894ed'] = {"dfnID": "832894ed", "url": "https://tc39.es/ecma262/#sec-object.fromentries", "dfnText": "object.fromentries", "refSections": [{"refs": [{"id": "ref-for-sec-object.fromentries"}], "title": "6.5.3.6. The script.LocalValue Type"}], "external": true};
Expand Down

0 comments on commit 9cf6443

Please sign in to comment.