Add support for running script inside a sandbox #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foolip
approved these changes
Feb 23, 2022
| ## SandboxWindowProxy ## {#sandbox-sandboxwindowproxy} | ||
|
|
||
| <xmp class=idl> | ||
| [Exposed=] |
There was a problem hiding this comment.
Suggested change
| [Exposed=] | |
| [Exposed=Window] |
Maybe?
There was a problem hiding this comment.
I'm not sure. It isn't actually constructable from JS, or accessible from a Window global. But of course you can access as the global of a sandbox.
This allows us to get a realm id back when we execute in a sandbox.
The main change here is that the target type allows specifying a sandbox name, and when a name is supplied, we got or create a sandbox for the given context with the given name. The details of how sandboxes actually work are intentionally elided for now, since that's more complex to specify. But some non-normative hints about their properties are given to sketch out the direction in which things are moving.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the API surface for running script inside a sandbox whilst omitting all detail about how a sandbox might work.
The API model is that when executing script in a context you can provide a sandbox name, which will cause a sandbox with that name to be used, creating it if necessary. If you already created the sandobx, you can also use the realm id directly.
This currently doesn't add any addition functionality inside the sandbox except for the sandboxing.
💥 Error: 500 Internal Server Error 💥
PR Preview failed to build. (Last tried on Mar 9, 2022, 4:38 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.