Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prompt handler #681

Merged
merged 4 commits into from
Jun 24, 2024
Merged

Prompt handler #681

merged 4 commits into from
Jun 24, 2024

Commits on Jun 24, 2024

  1. Support user prompt handlers for BiDi sessions 

    The key part of this is that with BiDi HTML calls into the spec when
it's going to show a prompt. So at that point we can see if there's a
handler defined, and if so return the handler to HTML.

All the actual logic to handle the dialogs ends up in the HTML spec.

From the BiDi point of view, the intended lifecycle is that you always
get the session.userPromptOpened and session.userPromptClosed events,
even if the prompt is automatically handled. But the
session.UserPromptOpened event gets a new `handler` property that
tells you whether the prompt will be automatically handled; if this is
set to "none" the automation has to send a session.handleUserPrompt
command (or wait for the prompt to be dismissed by the user).
    @jgraham
    jgraham committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    c0db447 View commit details
    Browse the repository at this point in the history

  2. Add a type field on the userPromptClosed event

    @jgraham
    jgraham committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    4f86bb3 View commit details
    Browse the repository at this point in the history

  3. Only allow full object prompt handlers for BiDi-only sessions

    @jgraham
    jgraham committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    c4281a6 View commit details
    Browse the repository at this point in the history

  4. Convert user prompt types into a separate type

    @jgraham
    jgraham committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    2ba6dce View commit details
    Browse the repository at this point in the history