Introduce subscription IDs #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/flat-subscribe
branch
2 times, most recently
from
89afc76 to
722f856
Compare
|
@jgraham I started a draft for managing subscriptions using a single list. I hope it is somewhat readable and if you think it is going in the right direction, I will work on TODOs and trying to make it landable. |
jgraham
reviewed
Dec 6, 2024
OrKoN
force-pushed
the
orkon/flat-subscribe
branch
from
722f856 to
e9362fe
Compare
OrKoN
changed the title
jgraham
requested changes
Dec 10, 2024
There was a problem hiding this comment.
Generally I think this is correct, but some of the use of spec primitives needs to be tightened up.
Also I think this model where we start with maximally compact structs with sets of both events and contexts, but in unsubscription break them apart into one struct per event is an awkward tradeoff
OrKoN
force-pushed
the
orkon/flat-subscribe
branch
6 times, most recently
from
ce03187 to
a8a897f
Compare
jgraham
requested changes
Dec 13, 2024
OrKoN
commented
Dec 13, 2024
OrKoN
force-pushed
the
orkon/flat-subscribe
branch
2 times, most recently
from
50c1eb3 to
fda1c58
Compare
sadym-chromium
approved these changes
Dec 17, 2024
jgraham
requested changes
Dec 18, 2024
OrKoN
force-pushed
the
orkon/flat-subscribe
branch
3 times, most recently
from
aba4af5 to
e28e69f
Compare
Co-authored-by: Maksim Sadym <69349599+sadym-chromium@users.noreply.github.com>
Co-authored-by: Maksim Sadym <69349599+sadym-chromium@users.noreply.github.com>
Co-authored-by: Maksim Sadym <69349599+sadym-chromium@users.noreply.github.com>
Co-authored-by: Maksim Sadym <69349599+sadym-chromium@users.noreply.github.com>
Co-authored-by: Maksim Sadym <69349599+sadym-chromium@users.noreply.github.com>
Co-authored-by: Maksim Sadym <69349599+sadym-chromium@users.noreply.github.com>
Co-authored-by: Maksim Sadym <69349599+sadym-chromium@users.noreply.github.com>
Co-authored-by: Maksim Sadym <69349599+sadym-chromium@users.noreply.github.com>
Co-authored-by: Maksim Sadym <69349599+sadym-chromium@users.noreply.github.com>
Co-authored-by: Maksim Sadym <69349599+sadym-chromium@users.noreply.github.com>
Co-authored-by: jgraham <james@hoppipolla.co.uk>
Co-authored-by: jgraham <james@hoppipolla.co.uk>
OrKoN
force-pushed
the
orkon/flat-subscribe
branch
from
fc147ba to
a6cae3f
Compare
2 tasks
|
I filed GoogleChromeLabs/chromium-bidi#2925 to track the work on implementation and WPT |
github-actions bot
added a commit
that referenced
this pull request
Dec 20, 2024
SHA: 60b9cc8 Reason: push, by OrKoN Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements subscription IDs which can be used to unsubscribe from events. The specification is refactored
to operate on a list of subscriptions.
Preview | Diff