Use actions queue when dispatching undo actions from "Release Actions" #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, I actually missed that we also have to enqueue the retrieval of the |
whimboo
force-pushed
the
release-actions-dispatch
branch
from
16453c9
to
0c2858c
Compare
whimboo
force-pushed
the
release-actions-dispatch
branch
from
0c2858c
to
b1a5a4d
Compare
|
This PR should be ready for review now. Thanks. |
whimboo
commented
Oct 30, 2024
Comment on lines
+10321
to
+10337
| <li><p>Let <var>token</var> be a new unique identifier. | ||
|
|
||
| <li><p>Enqueue <var>token</var> in <var>input state</var>'s <a>actions | ||
| queue</a>. | ||
|
|
||
| <li><p>Wait for <var>token</var> to be the first item | ||
| in <var>input state</var>'s <a>actions queue</a>. | ||
|
|
||
| <aside class=note> | ||
| <p>This ensures that only one set of actions can be run at a time, | ||
| and therefore different actions commands using the same underlying | ||
| state don't race. In a session that is only a HTTP session only one | ||
| command can run at a time, so this will never block. But other | ||
| session types can allow running multiple commands in parallel, in | ||
| which case this is necessary to ensure sequential access. | ||
| </aside> | ||
|
|
There was a problem hiding this comment.
@jgraham this is a bit of duplication but I hope it's fine. Otherwise we might have to create a new algorithm, that is just waiting for the token to be first in the queue.
There was a problem hiding this comment.
I think factoring this out into a new algorithm would be better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1837.
@jgraham could you please check? I hope that this is fine - it at least matches what we use in Firefox now when dispatching the actions from the parent process and it works fine. Thanks.
Preview | Diff